From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Thomas Winischhofer <thomas@winischhofer.net>,
Joe Perches <joe@perches.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] video: fbdev: sis: delete double assignment
Date: Mon, 25 Aug 2014 11:36:41 +0000 [thread overview]
Message-ID: <CAMuHMdXuL_0ZAXC-hDZ7bm8xxXYpU5cU9d11D2PG-7e_VA584Q@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1408242040020.2066@localhost6.localdomain6>
Hi Julia,
On Sun, Aug 24, 2014 at 8:40 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>> > ---
>> > The patches in this series do not depend on each other.
>> >
>> > This changes the semantics of the code and is not tested.
>>
>> Hence I think you should change the subject of the patch, so it's obvious
>> some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment".
>
> Do you want me to resend this patch with the new subject, or just keep it
> in mind for the future?
That's up to the fbdev maintainer.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2014-08-25 11:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1408818808-18850-1-git-send-email-Julia.Lawall@lip6.fr>
2014-08-23 18:33 ` [PATCH 2/7] video: fbdev: intelfb: delete double assignment Julia Lawall
2014-08-26 10:56 ` Tomi Valkeinen
2014-08-23 18:33 ` [PATCH 6/7] video: fbdev: sis: " Julia Lawall
2014-08-24 18:21 ` Geert Uytterhoeven
2014-08-24 18:40 ` Julia Lawall
2014-08-25 11:36 ` Geert Uytterhoeven [this message]
2014-08-26 10:51 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXuL_0ZAXC-hDZ7bm8xxXYpU5cU9d11D2PG-7e_VA584Q@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=thomas@winischhofer.net \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).