[PATCH 0/4] Cleanups and fix for video/pxa3xx-gcu

[PATCH 0/4] Cleanups and fix for video/pxa3xx-gcu

[Daniel Mack]

Here are some cleanups for the pxa3xx-gcu driver. Patch 3/4 is actually
a real bugfix that is needed since the misc code doesn't set
file->private_data for us implicitly anymore.

The rest are just straight-forward cleanups.

Thanks,
Daniel


Daniel Mack (4):
  video: pxa3xx-gcu: rename some symbols
  video: pxa3xx-gcu: pass around struct device *
  video: pxa3xx-gcu: provide an empty .open call
  video: pxa3xx-gcu: switch to devres functions

 drivers/video/pxa3xx-gcu.c | 191 +++++++++++++++++++--------------------------
 1 file changed, 81 insertions(+), 110 deletions(-)

-- 
1.8.5.3

Re: [PATCH 0/4] Cleanups and fix for video/pxa3xx-gcu

[Haojian Zhuang]

On Thu, Mar 6, 2014 at 12:12 AM, Daniel Mack <zonque@gmail.com> wrote:
> Here are some cleanups for the pxa3xx-gcu driver. Patch 3/4 is actually
> a real bugfix that is needed since the misc code doesn't set
> file->private_data for us implicitly anymore.
>
> The rest are just straight-forward cleanups.
>
> Thanks,
> Daniel
>
>
> Daniel Mack (4):
>   video: pxa3xx-gcu: rename some symbols
>   video: pxa3xx-gcu: pass around struct device *
>   video: pxa3xx-gcu: provide an empty .open call
>   video: pxa3xx-gcu: switch to devres functions
>
>  drivers/video/pxa3xx-gcu.c | 191 +++++++++++++++++++--------------------------
>  1 file changed, 81 insertions(+), 110 deletions(-)
>
> --
> 1.8.5.3
>

Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>

Re: [PATCH 0/4] Cleanups and fix for video/pxa3xx-gcu

[Daniel Mack]

On 03/06/2014 03:09 AM, Haojian Zhuang wrote:
> On Thu, Mar 6, 2014 at 12:12 AM, Daniel Mack <zonque@gmail.com> wrote:
>> Here are some cleanups for the pxa3xx-gcu driver. Patch 3/4 is actually
>> a real bugfix that is needed since the misc code doesn't set
>> file->private_data for us implicitly anymore.
>>
>> The rest are just straight-forward cleanups.
>>
>> Thanks,
>> Daniel
>>
>>
>> Daniel Mack (4):
>>   video: pxa3xx-gcu: rename some symbols
>>   video: pxa3xx-gcu: pass around struct device *
>>   video: pxa3xx-gcu: provide an empty .open call
>>   video: pxa3xx-gcu: switch to devres functions
>>
>>  drivers/video/pxa3xx-gcu.c | 191 +++++++++++++++++++--------------------------
>>  1 file changed, 81 insertions(+), 110 deletions(-)
>>

> Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>

Thanks Haojian!

Given that this driver doesn't actually have any connection points to
the framebuffer or video subsystem (despite its location) maybe you can
just take these patches through your pxa tree? It's a PXA3xx specific
device, after all. Jean-Christophe, Tomi - any objections?

The driver is also broken since awhile, and the fact that nobody noticed
tells me that our platform is most probably the only real user.


Thanks,
Daniel

Re: [PATCH 0/4] Cleanups and fix for video/pxa3xx-gcu

[Haojian Zhuang]

On Thu, Mar 6, 2014 at 5:09 PM, Daniel Mack <zonque@gmail.com> wrote:
> On 03/06/2014 03:09 AM, Haojian Zhuang wrote:
>> On Thu, Mar 6, 2014 at 12:12 AM, Daniel Mack <zonque@gmail.com> wrote:
>>> Here are some cleanups for the pxa3xx-gcu driver. Patch 3/4 is actually
>>> a real bugfix that is needed since the misc code doesn't set
>>> file->private_data for us implicitly anymore.
>>>
>>> The rest are just straight-forward cleanups.
>>>
>>> Thanks,
>>> Daniel
>>>
>>>
>>> Daniel Mack (4):
>>>   video: pxa3xx-gcu: rename some symbols
>>>   video: pxa3xx-gcu: pass around struct device *
>>>   video: pxa3xx-gcu: provide an empty .open call
>>>   video: pxa3xx-gcu: switch to devres functions
>>>
>>>  drivers/video/pxa3xx-gcu.c | 191 +++++++++++++++++++--------------------------
>>>  1 file changed, 81 insertions(+), 110 deletions(-)
>>>
>
>> Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
>
> Thanks Haojian!
>
> Given that this driver doesn't actually have any connection points to
> the framebuffer or video subsystem (despite its location) maybe you can
> just take these patches through your pxa tree? It's a PXA3xx specific
> device, after all. Jean-Christophe, Tomi - any objections?
>

If Jean or Tomi acked on this series, I can merge them into my pxa tree.

Best Regards
Haojian

Re: [PATCH 0/4] Cleanups and fix for video/pxa3xx-gcu

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

On 06/03/14 11:09, Daniel Mack wrote:
> On 03/06/2014 03:09 AM, Haojian Zhuang wrote:
>> On Thu, Mar 6, 2014 at 12:12 AM, Daniel Mack <zonque@gmail.com> wrote:
>>> Here are some cleanups for the pxa3xx-gcu driver. Patch 3/4 is actually
>>> a real bugfix that is needed since the misc code doesn't set
>>> file->private_data for us implicitly anymore.
>>>
>>> The rest are just straight-forward cleanups.
>>>
>>> Thanks,
>>> Daniel
>>>
>>>
>>> Daniel Mack (4):
>>>   video: pxa3xx-gcu: rename some symbols
>>>   video: pxa3xx-gcu: pass around struct device *
>>>   video: pxa3xx-gcu: provide an empty .open call
>>>   video: pxa3xx-gcu: switch to devres functions
>>>
>>>  drivers/video/pxa3xx-gcu.c | 191 +++++++++++++++++++--------------------------
>>>  1 file changed, 81 insertions(+), 110 deletions(-)
>>>
> 
>> Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
> 
> Thanks Haojian!
> 
> Given that this driver doesn't actually have any connection points to
> the framebuffer or video subsystem (despite its location) maybe you can
> just take these patches through your pxa tree? It's a PXA3xx specific
> device, after all. Jean-Christophe, Tomi - any objections?
> 
> The driver is also broken since awhile, and the fact that nobody noticed
> tells me that our platform is most probably the only real user.

If these do not have any dependencies to non-fbdev patches, and nothing
else has dependencies to these patches, I'd rather take them via fbdev
tree, based on the file location. There shouldn't be any conflicts, but
just in case...

As a side note, I've got a drivers/video/ reorg patch series, possibly
headed for v3.15, which moves the pxa3xx-gcu file to
drivers/video/fbdev/. That's clearly not the right place for it, but I
think it's easier to move it along the other files, and later move it
back to drivers/video/.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

Re: [PATCH 0/4] Cleanups and fix for video/pxa3xx-gcu

[Daniel Mack]

On 03/06/2014 10:23 AM, Tomi Valkeinen wrote:
> On 06/03/14 11:09, Daniel Mack wrote:

>> Given that this driver doesn't actually have any connection points to
>> the framebuffer or video subsystem (despite its location) maybe you can
>> just take these patches through your pxa tree? It's a PXA3xx specific
>> device, after all. Jean-Christophe, Tomi - any objections?
>>
>> The driver is also broken since awhile, and the fact that nobody noticed
>> tells me that our platform is most probably the only real user.
> 
> If these do not have any dependencies to non-fbdev patches, and nothing
> else has dependencies to these patches, I'd rather take them via fbdev
> tree, based on the file location. There shouldn't be any conflicts, but
> just in case...

Ok for me. I really don't mind :)

> As a side note, I've got a drivers/video/ reorg patch series, possibly
> headed for v3.15, which moves the pxa3xx-gcu file to
> drivers/video/fbdev/.

Ah, ok. So then they really better go via your tree then.

> That's clearly not the right place for it, but I
> think it's easier to move it along the other files, and later move it
> back to drivers/video/.

Maybe it might be worth adding a subdirectory for hardware accelerators?
Because this is what the pxa3xx-gcu thing is all about really. And it's
only a tiny transport layer that passed commands between the hardware
block and a DirectFB userspace driver.


Thanks,
Daniel

Re: [PATCH 0/4] Cleanups and fix for video/pxa3xx-gcu

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

On 06/03/14 12:18, Daniel Mack wrote:

>> As a side note, I've got a drivers/video/ reorg patch series, possibly
>> headed for v3.15, which moves the pxa3xx-gcu file to
>> drivers/video/fbdev/.
> 
> Ah, ok. So then they really better go via your tree then.

Git should handle it fine, so it's not mandatory here. Still, I'd rather
have them via fbdev tree.

>> That's clearly not the right place for it, but I
>> think it's easier to move it along the other files, and later move it
>> back to drivers/video/.
> 
> Maybe it might be worth adding a subdirectory for hardware accelerators?
> Because this is what the pxa3xx-gcu thing is all about really. And it's
> only a tiny transport layer that passed commands between the hardware
> block and a DirectFB userspace driver.

Well, there's drivers/gpu/. It sounds like a good match, and by "sounds"
I mean the word "gpu" sounds like a good match. I'm not sure if other
people have opinions on what drivers/gpu/ should contain, though.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

Re: [PATCH 0/4] Cleanups and fix for video/pxa3xx-gcu

[Daniel Mack]

On 03/06/2014 11:30 AM, Tomi Valkeinen wrote:
> On 06/03/14 12:18, Daniel Mack wrote:

>>> That's clearly not the right place for it, but I
>>> think it's easier to move it along the other files, and later move it
>>> back to drivers/video/.
>>
>> Maybe it might be worth adding a subdirectory for hardware accelerators?
>> Because this is what the pxa3xx-gcu thing is all about really. And it's
>> only a tiny transport layer that passed commands between the hardware
>> block and a DirectFB userspace driver.
> 
> Well, there's drivers/gpu/. It sounds like a good match, and by "sounds"
> I mean the word "gpu" sounds like a good match. I'm not sure if other
> people have opinions on what drivers/gpu/ should contain, though.

Yes, you're right. Do you think we should do that in a 2nd step maybe,
after 3.15?


Daniel

Re: [PATCH 0/4] Cleanups and fix for video/pxa3xx-gcu

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

On 06/03/14 12:53, Daniel Mack wrote:
> On 03/06/2014 11:30 AM, Tomi Valkeinen wrote:
>> On 06/03/14 12:18, Daniel Mack wrote:
> 
>>>> That's clearly not the right place for it, but I
>>>> think it's easier to move it along the other files, and later move it
>>>> back to drivers/video/.
>>>
>>> Maybe it might be worth adding a subdirectory for hardware accelerators?
>>> Because this is what the pxa3xx-gcu thing is all about really. And it's
>>> only a tiny transport layer that passed commands between the hardware
>>> block and a DirectFB userspace driver.
>>
>> Well, there's drivers/gpu/. It sounds like a good match, and by "sounds"
>> I mean the word "gpu" sounds like a good match. I'm not sure if other
>> people have opinions on what drivers/gpu/ should contain, though.

I have applied this series to fbdev tree for 3.15.

> Yes, you're right. Do you think we should do that in a 2nd step maybe,
> after 3.15?

Maybe. Then again, drivers/video is not so bad a location, after fbdev
stuff has been moved to drivers/video/fbdev/. drivers/gpu doesn't seem
to have a specific maintainer, but I guess that goes through drm maintainer.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]