Re: [PATCH 2/3] goldfish: Enable ACPI-based enumeration for goldfish framebuffer

Re: [PATCH 2/3] goldfish: Enable ACPI-based enumeration for goldfish framebuffer

[Bartlomiej Zolnierkiewicz]

[ + linux-fbdev ML ]

Hi,

On Thursday, May 31, 2018 03:02:51 PM rkir@google.com wrote:
> From: Yu Ning <yu.ning@intel.com>
> 
> Follow the same way in which ACPI was enabled for goldfish battery. See
> commit d3be10e for details.

No commit d3be10e in upstream and -next kernels?

> Note that this patch also depends on commit af33cac.

ditto for commit af33ac

also commits should be described with the following format:

tag with the first 12 characters of the SHA-1 ID, and the one line summary,
i.e.:

e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Re: [PATCH 3/3] ANDROID: goldfish_fb: Set pixclock = 0

[Bartlomiej Zolnierkiewicz]

[ + linux-fbdev ML ]

On Thursday, May 31, 2018 03:02:52 PM rkir@google.com wrote:
> From: Christoffer Dall <christoffer.dall@linaro.org>
> 
> User space Android code identifies pixclock = 0 as a sign for emulation
> and will set the frame rate to 60 fps when reading this value, which is
> the desired outcome.
> 
> Change-Id: I759bf518bf6683446bc786bf1be3cafa02dd8d42

please drop your local Change-Id from the upstream kernel submissions

> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

your S-o-b line is also needed

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Re: [PATCH 3/3] ANDROID: goldfish_fb: Set pixclock = 0

[Roman Kiryanov]

Hi,

thank you for reviewing our patches. I sent "v2".

Regards,
Roman.
On Fri, Jun 8, 2018 at 9:24 AM Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
>
> [ + linux-fbdev ML ]
>
> On Thursday, May 31, 2018 03:02:52 PM rkir@google.com wrote:
> > From: Christoffer Dall <christoffer.dall@linaro.org>
> >
> > User space Android code identifies pixclock = 0 as a sign for emulation
> > and will set the frame rate to 60 fps when reading this value, which is
> > the desired outcome.
> >
> > Change-Id: I759bf518bf6683446bc786bf1be3cafa02dd8d42
>
> please drop your local Change-Id from the upstream kernel submissions
>
> > Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> your S-o-b line is also needed
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>