From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Date: Mon, 21 Oct 2019 09:58:37 +0000 Subject: Re: [PATCH 05/46] ARM: pxa: split up mach/hardware.h Message-Id: List-Id: References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-5-arnd@arndb.de> In-Reply-To: <20191018154201.1276638-5-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: Alexandre Belloni , Linux USB List , Viresh Kumar , Linus Walleij , Linux Fbdev development list , Dominik Brodowski , linux-mtd@lists.infradead.org, Pavel Machek , Robert Jarzmik , linux-clk , linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, linux-input@vger.kernel.org, Michael Turquette , Guenter Roeck , linux-watchdog@vger.kernel.org, alsa-devel@alsa-project.org, Linux PM , Haojian Zhuang , Mark Brown , Jacek Anaszewski , Linux ARM , Stephen Boyd , Greg Kroah-Hartman , dri-devel , Dmitry Torokhov , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Daniel Mack On Fri, 18 Oct 2019 at 17:43, Arnd Bergmann wrote: > > The mach/hardware.h is included in lots of places, and it provides > three different things on pxa: > > - the cpu_is_pxa* macros > - an indirect inclusion of mach/addr-map.h > - the __REG() and io_pv2() helper macros > > Split it up into separate and mach/pxa-regs.h > headers, then change all the files that use mach/hardware.h to > include the exact set of those three headers that they actually > need, allowing for further more targeted cleanup. > > linux/soc/pxa/cpu.h can remain permanently exported and is now in > a global location along with similar headers. pxa-regs.h and > addr-map.h are only used in a very small number of drivers now > and can be moved to arch/arm/mach-pxa/ directly when those drivers > are to pass the necessary data as resources. > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Viresh Kumar > Cc: Dmitry Torokhov > Cc: Jacek Anaszewski > Cc: Pavel Machek > Cc: Ulf Hansson > Cc: Dominik Brodowski > Cc: Alexandre Belloni > Cc: Greg Kroah-Hartman > Cc: Guenter Roeck > Cc: Mark Brown > Cc: linux-clk@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Cc: linux-input@vger.kernel.org > Cc: linux-leds@vger.kernel.org > Cc: linux-mmc@vger.kernel.org > Cc: linux-mtd@lists.infradead.org > Cc: linux-rtc@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Cc: linux-watchdog@vger.kernel.org > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann [...] For the mmc part: Acked-by: Ulf Hansson