From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Eyüp Kerem Baş" <baseyupkerem@gmail.com>,
sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org
Cc: <linux-fbdev@vger.kernel.org>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: sm750fb: add missing const to g_fbmode array
Date: Sun, 15 Feb 2026 18:26:46 -0600 [thread overview]
Message-ID: <DGFYKGV9KCHJ.18PNMD6MZ52FR@gmail.com> (raw)
In-Reply-To: <20260215213102.111117-1-baseyupkerem@gmail.com>
On Sun Feb 15, 2026 at 3:31 PM CST, Eyüp Kerem Baş wrote:
> Checkpatch reported a warning that the static const char * array should probably be static const char * const. This patch adds the missing const keyword to g_fbmode array, moving it to read-only memory.
Please keep a maximum of 75 characters per line. Next time when
submitting a patch use "$ ./scripts/checkpatch.pl --strict <patch>" to
catch things like this.
Thanks,
ET
>
> Signed-off-by: Eyüp Kerem Baş <baseyupkerem@gmail.com>
> ---
prev parent reply other threads:[~2026-02-16 0:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 21:31 [PATCH] staging: sm750fb: add missing const to g_fbmode array Eyüp Kerem Baş
2026-02-16 0:26 ` Ethan Tidmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGFYKGV9KCHJ.18PNMD6MZ52FR@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=baseyupkerem@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox