From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012070.outbound.protection.outlook.com [40.107.200.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8948397695; Mon, 16 Mar 2026 13:19:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.70 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773667163; cv=fail; b=dArJFbRpLT4zuHBA9sdcelN8UApg7N2JjHBGplEaauXp4PZRGLVHCFXZBfG6KAWADjRWHUdeWp80RpY8iaLZrKsS32y1NOIhbEjgusT5S3aE55JtSqfHbn0vSi864t5Oo0VApICWp26WHg/3CyX0ZbF31fWb1S+kNuWJ8ribfXE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773667163; c=relaxed/simple; bh=4BB3DY0OSQOW2rRqiRTmfqQASKYMzJhgcSut6O0IQpQ=; h=Content-Type:Date:Message-Id:To:Cc:Subject:From:References: In-Reply-To:MIME-Version; b=bWUxHr+SBQpEs9H3q2jmbHKu47gapTCY0+owSmKSI+vxUMZplUPQHI+Lw7Oa0p+MrynRL21b34q4ieu7uO+CL/2hdZGyJjNp6G4fp9ZMznWahUWSfjfafgfdUqhRlRmYQLVcnHqjY6U8MhuD4BznrPGexFYLoo/u8HVr7S8GfC8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=b3XDidlq; arc=fail smtp.client-ip=40.107.200.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="b3XDidlq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cYH/JxFensDA8boLhzoMXg7xcPiMbjpAzbPxWs2ZB97WQPjaMQC5ihXAeCVE5wXHfXPxmDipM6/3AGWEtuhxTxvq5iotzNFkkWRtI6pYOdHwJwaAXqC6WKrwSeWVVFDsEWqjHuSJ+l5ZIO6pQpL+YmzCyK0d1l+AOeUTy6ZcCchA0Bo3ovUD7YyQaPJShQwITyH5N9Loizg5Tg0PpUWn1dUpG6Dr69XWGfhjKf52If9zPB6NBFnFksPkuPP/mVBoPNA9gUfCT/S+UOnaiNpqayLCbebq1DG6ounFAajHOpn0QgPFRuH7IRkd/2tSevf96QSCsvPD/HpMB0ewBXKBqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M7COxVHa2vwPcZ0LhUbw9E25wyR9hV02Y5rZIikgRos=; b=P46SbIgN7M4cLGeEoN+mpejB8i83vrE/CQVnfeaUsM47FMkB6JbXheF2a41OQvya8WDC/LFPJvRlyzaAJixhWqbZr44dXlKJKJBICmsMJhXVv3fcBQEWU4zbNgCKNF6cCE4Aslm9ucycD9w5ox5TfojfkMNZeWvqLxLAlHo3DXQAVNj3Kkp9SUYzwYAmPgD/FDEruHjH+FkrZWYG6xsIh+isgYIOH3FRuXQYo/MPLFxdYMl2bbvQOVWegfs/eKy8xkcNVGa0IzjEM1946gnk0Bl0iAirUn2pWHVm3DGSRMKQ+8gxioPkjwbq6Kvyp1yBH0Ci4RLfvbQ7jcCghPpAZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M7COxVHa2vwPcZ0LhUbw9E25wyR9hV02Y5rZIikgRos=; b=b3XDidlq5+L208uMCFTzSrZcjbrGxe6k7lS5Dk8NMf6Ktq++TK4W/WMVanq2/H0y5aEoPRiReQdPKTd7Pihahxi6lyUtpJJhMHSJaoolJTECfSyW7+WigoTzpYy33bhrw4iSuqp8Gov7nuxrZJewR6Gj4wnyGraMhiR1/OxFm9R/m6HRMN1Rnjc10Y7YJRfEfldVc4FY4T30s6Ig8NEv4jKDjZMm0/SpHmSSdWyArKP+YQpDv4nODsiS0NlAYtR5Fw5d0PY7bYZ+WBqhCcbo6OcrV2m9JfDhLkjvxYAf3a3p40Bq6sPYjHVE9DpHKEgDSr49mHHoHYvUuFFmrYOk0A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by MW4PR12MB7013.namprd12.prod.outlook.com (2603:10b6:303:218::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.17; Mon, 16 Mar 2026 13:19:14 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9723.016; Mon, 16 Mar 2026 13:19:14 +0000 Content-Type: text/plain; charset=UTF-8 Date: Mon, 16 Mar 2026 22:19:10 +0900 Message-Id: To: "Joel Fernandes" Cc: , "Miguel Ojeda" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Danilo Krummrich" , "Dave Airlie" , "Daniel Almeida" , "Koen Koning" , , , , "Nikola Djukic" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Jonathan Corbet" , "Alex Deucher" , =?utf-8?q?Christian_K=C3=B6nig?= , "Jani Nikula" , "Joonas Lahtinen" , "Rodrigo Vivi" , "Tvrtko Ursulin" , "Huang Rui" , "Matthew Auld" , "Matthew Brost" , "Lucas De Marchi" , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , "Helge Deller" , "Alex Gaynor" , "Boqun Feng" , "John Hubbard" , "Alistair Popple" , "Timur Tabi" , "Edwin Peer" , "Andrea Righi" , "Andy Ritger" , "Zhi Wang" , "Balbir Singh" , "Philipp Stanner" , "Elle Rhumsaa" , , "Eliot Courtney" , , , , , , Subject: Re: [PATCH v9 05/23] gpu: nova-core: gsp: Expose total physical VRAM end from FB region info From: "Alexandre Courbot" Content-Transfer-Encoding: quoted-printable References: <20260311004008.2208806-1-joelagnelf@nvidia.com> <20260311004008.2208806-6-joelagnelf@nvidia.com> In-Reply-To: <20260311004008.2208806-6-joelagnelf@nvidia.com> X-ClientProxiedBy: TY4PR01CA0120.jpnprd01.prod.outlook.com (2603:1096:405:379::12) To MN2PR12MB3997.namprd12.prod.outlook.com (2603:10b6:208:161::11) Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|MW4PR12MB7013:EE_ X-MS-Office365-Filtering-Correlation-Id: 614f462c-66af-4d1b-7515-08de835e9e1c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|10070799003|376014|7416014|1800799024|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: WsUiJTti41xOglmYq2GkGNG24rNTWDWwJBlAzlv08nYiMzooq2BnISS25r3z/ZbBWA84dVkH/i/qGwlbyJQM5Y2XjrxFew8QrypjP99JiXpt6AMwygnwwmJYqUeMC+x7BxLb9oHYGBKwnbs4tcjx839tWpFW1aWfRcV87meSfJnSa9UTs70N3lF4RtL5kmrQsYa6EOUa5bGtBLkwDvuiSo7WnH8N++rVkTnTilDZ8EEdmWqb5ebb3QPbx/BLyVss3rXciY/hOk7UcFhifOYCxNHCbb864bK+lCqOJfEPi2WJ7mCnqkeqAQPQtT/P1VCAaTjuLdkeWXz09fZICBhIHa5zC9TVTxPaFQsVfEIubdKVMKqDFGLcSVBucvHV4ZVuH6iFjlXGau4S6DlZFR0RFmlAmsvyI/NgjGp9tRAvXkXPnkT4lZO5GbbJw8D2kAoZqp8Bi57ELwQNTvvkVfmio/PZlzkddlpwIQNdDaT19DYAh+rE+c5mcKHUoP8qT+U1cw2+K6uJfgNB7EygVNWmn+HXxNqkDnMC/zPUegaGHrFN/UBw+2scKfB3blawX63+l4Jrbj7pklEce3d7zYz3CKaO7X5MhNcY7fCVSfEsNPFyriGSEf71IcStlnCOUPVkv4Zt/4nrzHc8qwFTMG7MwU0luwmEiknSBH0jF3OAp0sNB/VgyNjf5NdgNPIR3Bnqm0Nqzc6s5C3BObFAniBDCAyqyJhvSRhhg4X+91sx0os= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(10070799003)(376014)(7416014)(1800799024)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEdZOWwyUjlQR1pDZmNpNEh6UzJtNTA4bVhpY1ZzUkp4QkhjNXE5Y0huS2Rr?= =?utf-8?B?dzlWOUMvc3ZmejFKK0Y5VCtxc0VSMkFLUWl1RkdFT3pDNnVwclNJQXJkUUd3?= =?utf-8?B?Tytlb2ZUamRITUwzT29jU0VJSyt4M0gyeEViRCtNb0VuOFkrSFBvcXZ2OWh6?= =?utf-8?B?bFdSTEowbkJWVkdia3NHb250R0I0RGh2aDBwcWtkOGFTWkpFVnBUTUxsSHpR?= =?utf-8?B?UWR0TE9LTnZVOS9wdnBaekFLcytxRlhLQUlCM0kzZ1NScWowb3J5T3VIUHZ6?= =?utf-8?B?N1RZSWZCamZTSnc5N05aZUczL21lV2NvQ05uSzlibXdYWXlUcHkzNEw2WTRm?= =?utf-8?B?NGVEblZodUdOL0ZQSUdFeUN6ODV4L0VLNE51SFlsSUx1cHBQVHl2aGhKYjFx?= =?utf-8?B?TkIrQXNiSFE1SVZPOFRydlR1SllneWsxckpIWk9UMzhhT2JoeHdoTDQ2VFZF?= =?utf-8?B?RlIzbzVqamVlSlJ6M0JabmI4Wnpna2lTU1pDTFpWZTg3WnlvbDhJRUI3MGRx?= =?utf-8?B?Nk5jelhzR29sNHFnYmpja0hnYWFkMk5RNWg2MVp4bGduNmZKZWd6STB0ejRM?= =?utf-8?B?NTNSZ3ZsVEV6R1dtanZ3OEtSSmtWRmFzQU01azhIYi90VzNZSU05dytKZkNv?= =?utf-8?B?cVNmT2psWTl1blRuQzlNYktZWk9ydHo1MDFROS8yckE2cy9xNUxOVmd1K1Nx?= =?utf-8?B?bHpkWTR5K0JSMFBUUlFLYlZUUUo5UVpiMTNVZVluTXcxTDR3eStqSTRleEky?= =?utf-8?B?Q0JiZHFVaDR6eDBnQzdTd0Vod3hhcHB4TmxyMEIrWThkYVU5Q3ZjRjBBVVdv?= =?utf-8?B?WTBpTzl1Z2JPNWZZWFBxY3V4dVRPUjk2U2FaZWFnOVcrOUZiUGhMQ2lZWHlw?= =?utf-8?B?b09mSmFhZHBOWnlVQXdNeVVPWkxxc29zNVdvMTZmSWs5N3dYVld0cERxZHBY?= =?utf-8?B?TTFlR0dsZnUzZ3YxSDhYVEd5ZW51MC9RcWxHNVVUUmV6T1ZTbFdVNlpCdWx1?= =?utf-8?B?WGdKQnYxaFl5TW5xN0VXQ0YvOHpvTUlBYUhzU0ZlYnMzZ2ROVEFVMGRRU1Jy?= =?utf-8?B?Q3FwRHNFOUNRZjl5ay9FOXVScmdQb2RPS0diZDRuVGZBbUF6T3dtb2d6MTVJ?= =?utf-8?B?THNMSlJ5YzN5ckVhdEQrNkJNbkYyQ0RuS0x2V21xMExObmZMUTJoOWJoOWtI?= =?utf-8?B?ZHljYVc3RGt6VndiRW5EL1l6Sm95UjBua2Y4aWJTL1BXa2NmTE1IK3c0QVZV?= =?utf-8?B?SDY5b0tUcWNVeVNvMjF4MngwMFJvb2xhK0VqdXZVTjRYenVmeUZUS2lZSVpx?= =?utf-8?B?aWlLSWk5UUpaS0dOcGZuL0NoTEFlMTlPS2Vsak1GRzhMbVVmaVhkcVdMN0hp?= =?utf-8?B?cWRkTzVCR05EZ21EYnBkR0dTRDN1RDRiTTc3VDJROEYrQkJsQ3hMQ09SNmNU?= =?utf-8?B?aXphbHhUTDUxeXUyR3c0VzV0Ujk0Q1JXS2QwOVp1WERYR1hBbVUwUVNTYmpu?= =?utf-8?B?TTUyaWxjT08wZVJLb2o3WFpqU3VDeGZ6cVRmWEM2OFFBVUZtV2lMeUUvVTl4?= =?utf-8?B?YkVqRndCcVhVSFVlNnA4akxCSnJ4NTRWbFFFQ3FwVCtBU2hUNEh5VTk4dzIv?= =?utf-8?B?TmdIK2hCZ3dSY21LeXVnb3RxUll4RTNiN0tyTmVYR1Nzdk0zR2grTFlGMy9O?= =?utf-8?B?Z1E1MXo4bUo1VS9CNjNLZW9JNU8yOXpOOFJoeGMyKzFoSW81cjZ5SW9UeWxG?= =?utf-8?B?N0pyYWQ3RHJuMTRQcmV5Y0RXSnJUUXVBdVF6cThpajlNUTJBN1g4cGhXdEp6?= =?utf-8?B?eFRwZHBJM3VLSkMrWXBZWVRsYWgyd3EyTXhWb3VPOUZTZjIrTm8rTGNuQmxY?= =?utf-8?B?T0dxOEt0SHRBUHJZU3YwL0hXcVNrWHQvN1d4b2FMdlpoTlJnUFZNRmJGR1RD?= =?utf-8?B?UjgvWDlPY08rZ1A5VU9aVmc5dHhGcUhPRStxRndhTjdTVXVPOHI0dmJMQU1N?= =?utf-8?B?MVlSbkZuQVQxMDV4THZ0UjA4aGV5R2hidmZKNnBzWEIyNm9YaFYvSGpGeVlM?= =?utf-8?B?cU9MQ1h5a2xJdTJtdGxhNVpsMm1sdENyZE1qbGo5YU4wZStrSVh3aEJaQ3FT?= =?utf-8?B?S3QzQjI2b2xBbXc1VlhXWWFIdUZCcy9wMmNxeUJ3NmVDN254WXMveWgyZ1dL?= =?utf-8?B?amNHbFlucVlrNVJPZi9VNEtsYkt0bGNYOXJPTEh3NW5jdjlVWHUyZmNnOFFV?= =?utf-8?B?dE02QmJqbzRLV0FGS0NFV2xtdHd5YzNwUHIwanBNYnp6amRqMnh3N01LZnRH?= =?utf-8?B?SkxJQXlibmErOHJnNHJtSGFHN1hnNnBHdGlMZWdwRnUwYUhmSW9qYWhudzll?= =?utf-8?Q?fzUuKgRAnYdiMeI3VfKbhdAcO4Q3dKClYRXwwdRcnN2pM?= X-MS-Exchange-AntiSpam-MessageData-1: bwMuh7+hFs089Q== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 614f462c-66af-4d1b-7515-08de835e9e1c X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3997.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2026 13:19:14.0354 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nM0wr68eA+gE98eocIk5V48FuTtUo/YEyCBnn3MWCqQBfwis9pwWncDm2Ne5rUKdDZo9nX1UESTxC0wLRTZvFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7013 On Wed Mar 11, 2026 at 9:39 AM JST, Joel Fernandes wrote: > Add `total_fb_end()` to `GspStaticConfigInfo` that computes the exclusive= end > address of the highest valid FB region covering both usable and GSP-reser= ved > areas. > > This allows callers to know the full physical VRAM extent, not just the > allocatable portion. > > Signed-off-by: Joel Fernandes > --- > drivers/gpu/nova-core/gsp/commands.rs | 6 ++++++ > drivers/gpu/nova-core/gsp/fw/commands.rs | 19 +++++++++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-cor= e/gsp/commands.rs > index 8d5780d9cace..389d215098c6 100644 > --- a/drivers/gpu/nova-core/gsp/commands.rs > +++ b/drivers/gpu/nova-core/gsp/commands.rs > @@ -193,6 +193,9 @@ pub(crate) struct GetGspStaticInfoReply { > /// Usable FB (VRAM) region for driver memory allocation. > #[expect(dead_code)] > pub(crate) usable_fb_region: Range, > + /// End of VRAM. > + #[expect(dead_code)] > + pub(crate) total_fb_end: u64, > } > =20 > impl MessageFromGsp for GetGspStaticInfoReply { > @@ -206,9 +209,12 @@ fn read( > ) -> Result { > let (base, size) =3D msg.first_usable_fb_region().ok_or(ENODEV)?= ; > =20 > + let total_fb_end =3D msg.total_fb_end().ok_or(ENODEV)?; > + > Ok(GetGspStaticInfoReply { > gpu_name: msg.gpu_name_str(), > usable_fb_region: base..base.saturating_add(size), > + total_fb_end, > }) > } > } > diff --git a/drivers/gpu/nova-core/gsp/fw/commands.rs b/drivers/gpu/nova-= core/gsp/fw/commands.rs > index cef86cab8a12..acaf92cd6735 100644 > --- a/drivers/gpu/nova-core/gsp/fw/commands.rs > +++ b/drivers/gpu/nova-core/gsp/fw/commands.rs > @@ -147,6 +147,25 @@ pub(crate) fn first_usable_fb_region(&self) -> Optio= n<(u64, u64)> { > } > None > } > + > + /// Compute the end of physical VRAM from all FB regions. > + pub(crate) fn total_fb_end(&self) -> Option { > + let fb_info =3D &self.0.fbRegionInfoParams; > + let mut max_end: Option =3D None; > + for i in 0..fb_info.numFBRegions.into_safe_cast() { > + if let Some(reg) =3D fb_info.fbRegion.get(i) { > + if reg.limit < reg.base { > + continue; > + } This is basically a repeat of the code of the previous patch. Let's implement an iterator over the FB memory regions (that filters out invalid regions) that we can leverage in both places so we don't need to repeat ourselves.