From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb Date: Sat, 13 Nov 2004 10:00:38 -0800 (PST) Message-ID: References: <200411080521.iA85LbG6025914@hera.kernel.org> <1100309972.20511.103.camel@gaston> <20041113112234.GA5523@bogon.ms20.nix> <200411132000.31465.adaplas@hotpop.com> Mime-Version: 1.0 Return-path: In-Reply-To: <200411132000.31465.adaplas@hotpop.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: , Guido Guenther , Benjamin Herrenschmidt , Linux Kernel list , Andrew Morton On Sat, 13 Nov 2004, Antonino A. Daplas wrote: > > Why not use in_be* and out_be* for __raw_read and raw_write? Please don't start using some stupid magic ppc-specific macros for a driver that has no reason to be PPC-specific. It then only causes bugs that show on one platform and not another. Linus