From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH] EFI framebuffer on EFI X86_64
Date: Wed, 4 Jul 2007 18:54:17 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0707041850500.10749@anakin> (raw)
In-Reply-To: <1183585851.16719.36.camel@caritas-dev.intel.com>
On Wed, 4 Jul 2007, Huang, Ying wrote:
> diff -uprN -X linux-2.6.21-orig/Documentation/dontdiff
> linux-2.6.21-orig/drivers/video/efifb.c
> linux-2.6.21-uefi-finaltest4/drivers/video/efifb.c
Your mail client seems to corrupt whitespace...
> + //size_total = screen_info.lfb_size * 65536;
Please don't use C++-style comments. You can use scripts/checkpatch.pl
to perform some basic style checks on your patches.
> +#ifndef __i386__
> + //screen_info.imacpm_seg = 0;
> +#endif
Superfluous block?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-07-04 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 21:50 [PATCH] EFI framebuffer on EFI X86_64 Huang, Ying
2007-07-04 16:54 ` Geert Uytterhoeven [this message]
2007-07-05 12:17 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707041850500.10749@anakin \
--to=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).