Re: [PATCH 11/20] cirrusfb: checkpatch.pl cleanup

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Sun, 26 Aug 2007, Antonino A. Daplas wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> This patch fixes over 850 errors and warnings pointed
> out by the checkpatch.pl script.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> Signed-off-by: Antonino Daplas <adaplas@gmail.com>
> ---
> 
>  drivers/video/cirrusfb.c | 1788 +++++++++++++++++++++++++---------------------
>  1 files changed, 983 insertions(+), 805 deletions(-)
> 
> diff --git a/drivers/video/cirrusfb.c b/drivers/video/cirrusfb.c
> index 8269d70..4c97c1d 100644
> --- a/drivers/video/cirrusfb.c
> +++ b/drivers/video/cirrusfb.c
> @@ -59,7 +59,7 @@ #include <asm/amigahw.h>
>  #endif
>  #ifdef CONFIG_PPC_PREP
>  #include <asm/machdep.h>
> -#define isPReP (machine_is(prep))
> +#define isPReP(machine_is(prep))
>  #else
>  #define isPReP 0
>  #endif

This chunk is bogus. Probably there should be a tab instead of a space to
silence checkpatch, or checkpatch should become smarter...

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/