From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 11/20] cirrusfb: checkpatch.pl cleanup Date: Mon, 27 Aug 2007 09:15:22 +0200 (CEST) Message-ID: References: <46D18888.10902@gmail.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1IPYop-0005Ol-QU for linux-fbdev-devel@lists.sourceforge.net; Mon, 27 Aug 2007 00:15:27 -0700 Received: from adicia.telenet-ops.be ([195.130.132.56]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1IPYon-0000iv-Br for linux-fbdev-devel@lists.sourceforge.net; Mon, 27 Aug 2007 00:15:27 -0700 In-Reply-To: <46D18888.10902@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Linux Fbdev development list Cc: Andrew Morton , Andy Whitcroft On Sun, 26 Aug 2007, Antonino A. Daplas wrote: > From: Krzysztof Helt > > This patch fixes over 850 errors and warnings pointed > out by the checkpatch.pl script. > > Signed-off-by: Krzysztof Helt > Signed-off-by: Antonino Daplas > --- > > drivers/video/cirrusfb.c | 1788 +++++++++++++++++++++++++--------------------- > 1 files changed, 983 insertions(+), 805 deletions(-) > > diff --git a/drivers/video/cirrusfb.c b/drivers/video/cirrusfb.c > index 8269d70..4c97c1d 100644 > --- a/drivers/video/cirrusfb.c > +++ b/drivers/video/cirrusfb.c > @@ -59,7 +59,7 @@ #include > #endif > #ifdef CONFIG_PPC_PREP > #include > -#define isPReP (machine_is(prep)) > +#define isPReP(machine_is(prep)) > #else > #define isPReP 0 > #endif This chunk is bogus. Probably there should be a tab instead of a space to silence checkpatch, or checkpatch should become smarter... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/