Re: [PATCH] tdfxfb: checkpatch fixes

[Geert Uytterhoeven <geert@linux-m68k.org>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: TEXT/PLAIN; charset=UTF-8, Size: 1852 bytes --]

On Fri, 7 Sep 2007, Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> This patch fixes all errors pointed by the checkpatch.pl
> script.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> ---
> 
> --- linux-2.6.23-mm/drivers/video/tdfxfb.c	2007-09-07 00:24:56.639073042 +0200
> +++ linux-2.6.23/drivers/video/tdfxfb.c	2007-09-07 00:28:13.378284570 +0200
> @@ -4,7 +4,7 @@
>   *
>   * Author: Hannu Mallat <hmallat@cc.hut.fi>
>   *
> - * Copyright © 1999 Hannu Mallat
> + * Copyright (C) 1999 Hannu Mallat
>   * All rights reserved
>   *
>   * Created      : Thu Sep 23 18:17:43 1999, hmallat

<switching-to-corporate-hat>
The legal departments of some companies allow to use the c-in-circle symbol,
others don't and require the c-between-parentheses, or vice versa.

As I guess checkpatch.pl complained about the presence of a non-UTF-8
character, perhaps it's safest to convert it to the UTF-8 c-in-circle
symbol?
</switching-to-corporate-hat>

> @@ -72,9 +72,9 @@
>  
>  #undef TDFXFB_DEBUG
>  #ifdef TDFXFB_DEBUG
> -#define DPRINTK(a,b...) printk(KERN_DEBUG "fb: %s: " a, __FUNCTION__ , ## b)
> +#define DPRINTK(a, b...) printk(KERN_DEBUG "fb: %s: " a, __FUNCTION__ , ## b)
>  #else
> -#define DPRINTK(a,b...)
> +#define DPRINTK(a, b...)
>  #endif
>  
>  #ifdef CONFIG_MTRR

What about an unconditional

| #define DPRINTK(a, b...) pr_debug("fb: %s: " a, __FUNCTION__ , ## b)

That way we'll get printf-format checking even if TDFXFB_DEBUG is not
defined.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[-- Attachment #2: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 182 bytes --]

_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel