From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] logo: move declarations of logos to linux_logo.h Date: Fri, 14 Dec 2007 21:49:03 +0100 (CET) Message-ID: References: <20071209214027.GG9440@joi> <20071213023111.30ddc487.akpm@linux-foundation.org> <20071213213130.GA1822@joi> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-1463808512-1321829784-1197665343=:4881" Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1J3HT9-0004Md-Lr for linux-fbdev-devel@lists.sourceforge.net; Fri, 14 Dec 2007 12:49:15 -0800 Received: from ananke.telenet-ops.be ([195.130.137.78]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1J3HT5-0007ot-VY for linux-fbdev-devel@lists.sourceforge.net; Fri, 14 Dec 2007 12:49:15 -0800 In-Reply-To: <20071213213130.GA1822@joi> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: linux-fbdev-devel@lists.sourceforge.net Cc: Andrew Morton , Sam Ravnborg , linux-kernel@vger.kernel.org, Antonino Daplas This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463808512-1321829784-1197665343=:4881 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 13 Dec 2007, Marcin Slusarz wrote: > On Thu, Dec 13, 2007 at 02:31:11AM -0800, Andrew Morton wrote: > > On Sun, 9 Dec 2007 22:40:31 +0100 Marcin =C5=9Alusarz wrote: > > > > > logo: move declarations of logos to linux_logo.h > > > > > > there was a mismatch between externs in logo.c and code generated b= y pnmtologo > > > (on old tree, you need to rm drivers/video/logo/logo_*.c before com= pilation) > > > > This patch (after I fixed it) keeps on causing trouble: mismatches be= tween > > the header file declarations and the actual definitions of the lookup > > tables. This happens as I apply and unapply the patch. > > > > It _shouldn't_ happen, but there would appear to be some missing make= file > > rules. I guess the C files aren't being regenerated when > > scripts/pnmtologo.c has been altered, so the C files aren't matching = the > > header which this patch alters. >=20 > Ok, updated patch below: >=20 > logo: move declarations of logos to linux_logo.h >=20 > there was a mismatch between externs in logo.c and code generated by pn= mtologo This may cause section conflicts, cfr. http://lkml.org/lkml/2007/10/24/65 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m6= 8k.org In personal conversations with technical people, I call myself a hacker. = But when I'm talking to journalists I just say "programmer" or something like= that. -- Linus Torvalds ---1463808512-1321829784-1197665343=:4881 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ---1463808512-1321829784-1197665343=:4881 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-fbdev-devel mailing list Linux-fbdev-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel ---1463808512-1321829784-1197665343=:4881--