From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Thomas Pfaff <tpfaff@pcs.com>, adaplas@gmail.com
Subject: Re: [PATCH] [Resend] fbcon : fix color generation for monochrome framebuffer
Date: Fri, 1 Feb 2008 09:02:17 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0802010859230.22762@anakin> (raw)
In-Reply-To: <20080131140701.b584430e.akpm@linux-foundation.org>
On Thu, 31 Jan 2008, Andrew Morton wrote:
> On Mon, 28 Jan 2008 11:03:38 +0100 (CET) Thomas Pfaff <tpfaff@pcs.com> wrote:
> > +#define attr_bgcol_ec(bgshift,vc,info) \
> > + attr_col_ec(bgshift,vc,info,0);
> > +#define attr_fgcol_ec(fgshift,vc,info) \
> > + attr_col_ec(fgshift,vc,info,1);
> > +
>
> Could be implemented as C functions.
I don't see a real advantage in using a function instead. It will just
become longer. There won't be any additional type checking.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-02-01 8:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 10:03 [PATCH] [Resend] fbcon : fix color generation for monochrome framebuffer Thomas Pfaff
2008-01-31 22:07 ` Andrew Morton
2008-01-31 22:18 ` Andrew Morton
2008-02-01 8:02 ` Geert Uytterhoeven [this message]
2008-02-01 11:58 ` Thomas Pfaff
2008-02-01 12:24 ` Geert Uytterhoeven
2008-02-01 13:01 ` Thomas Pfaff
2008-02-01 13:38 ` Geert Uytterhoeven
2008-02-01 13:55 ` Thomas Pfaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0802010859230.22762@anakin \
--to=geert@linux-m68k.org \
--cc=adaplas@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=tpfaff@pcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox