Re: [PATCH] [Resend] fbcon : fix color generation for monochrome framebuffer

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Fri, 1 Feb 2008, Thomas Pfaff wrote:
> On Fri, 1 Feb 2008, Geert Uytterhoeven wrote:
> > On Fri, 1 Feb 2008, Thomas Pfaff wrote:
> > > On Thu, 31 Jan 2008, Andrew Morton wrote:
> > > > On Mon, 28 Jan 2008 11:03:38 +0100 (CET)
> > > If the functions should be deinlined someone should decide where to put them. 
> > > Since they must be exported i would avoid to put them into fbcon.c, this would 
> > > lead to cross dependencies.
> > > I would suggest to put the prototype into <linux/fb.h> and the definition into 
> > > fbcmap.c instead, but i am unsure whether they really belong there.
> > 
> > General note: functions in header files must be inline, else you get
> > multiple definitions of the same symbol.
> 
> Of course you are right but this does not answer my question:
> Where should i put a mono_col / attr_col_ec if they must be deinlined ?

Sorry, I misunderstood. I thought you meant the macros that Andrew
wanted to be turned into functions.

> My suggestion is a fb_mono_col / fb_attr_col_ec in fbcmap.c.

As they're used by fbcon only, not by fbdev, I'd suggest fbcon.c.

pmag-aa-fb.c is the only other user, but it's broken anyway because it
still uses the 2.4.x fbdev API.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/