From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] [Resend] fbcon : fix color generation for monochrome framebuffer Date: Fri, 1 Feb 2008 14:38:15 +0100 (CET) Message-ID: References: <20080131140701.b584430e.akpm@linux-foundation.org> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JKw62-0001TR-0z for linux-fbdev-devel@lists.sourceforge.net; Fri, 01 Feb 2008 05:38:22 -0800 Received: from monty.telenet-ops.be ([195.130.132.56]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1JKw60-0003k1-Bo for linux-fbdev-devel@lists.sourceforge.net; Fri, 01 Feb 2008 05:38:21 -0800 In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Thomas Pfaff Cc: Andrew Morton , linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com On Fri, 1 Feb 2008, Thomas Pfaff wrote: > On Fri, 1 Feb 2008, Geert Uytterhoeven wrote: > > On Fri, 1 Feb 2008, Thomas Pfaff wrote: > > > On Thu, 31 Jan 2008, Andrew Morton wrote: > > > > On Mon, 28 Jan 2008 11:03:38 +0100 (CET) > > > If the functions should be deinlined someone should decide where to put them. > > > Since they must be exported i would avoid to put them into fbcon.c, this would > > > lead to cross dependencies. > > > I would suggest to put the prototype into and the definition into > > > fbcmap.c instead, but i am unsure whether they really belong there. > > > > General note: functions in header files must be inline, else you get > > multiple definitions of the same symbol. > > Of course you are right but this does not answer my question: > Where should i put a mono_col / attr_col_ec if they must be deinlined ? Sorry, I misunderstood. I thought you meant the macros that Andrew wanted to be turned into functions. > My suggestion is a fb_mono_col / fb_attr_col_ec in fbcmap.c. As they're used by fbcon only, not by fbdev, I'd suggest fbcon.c. pmag-aa-fb.c is the only other user, but it's broken anyway because it still uses the 2.4.x fbdev API. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/