From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Bryan Wu <cooloney@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [PATCH 1/2] Blackfin Video Driver: Update the BF52x EZKIT video framebuffer driver according to LKML review
Date: Wed, 26 Mar 2008 13:32:27 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0803261331260.13478@anakin> (raw)
In-Reply-To: <1206580775-23929-2-git-send-email-cooloney@kernel.org>
On Wed, 26 Mar 2008, Bryan Wu wrote:
> @@ -552,11 +544,11 @@ static int __init bfin_t350mcqb_probe(struct platform_device *pdev)
> goto out7;
> }
>
> - if (request_irq(info->irq, (void *)bfin_t350mcqb_irq_error, IRQF_DISABLED,
> - "PPI ERROR", info) < 0) {
> + ret = request_irq(info->irq, (void *)bfin_t350mcqb_irq_error, IRQF_DISABLED,
^^^^^^^^
This cast should not be necessary. If it is, the signature of
bfin_t350mcqb_irq_error() is incorrect.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
prev parent reply other threads:[~2008-03-26 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 1:19 [PATCH 1/2] Blackfin Video Driver: Update the BF52x EZKIT video framebuffer driver according to LKML review Bryan Wu
2008-03-26 12:32 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0803261331260.13478@anakin \
--to=geert@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=cooloney@kernel.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).