Re: [SPAM] [PATCH 4/4 2.6.24] fbdev: platforming hecubafb and n411

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Fri, 4 Apr 2008, Jaya Kumar wrote:
> On Fri, Apr 4, 2008 at 6:37 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Thu, 3 Apr 2008, Jaya Kumar wrote:
> >  > This patch splits hecubafb into the platform independent hecubafb and
> >  > the platform dependent n411.
> >  >
> >  > Signed-off-by: Jaya Kumar <jayakumar.lkml@gmail.com>
> >  >
> >  > ---
> >  >
> >  >  drivers/video/hecubafb.c |  250 +++++++++--------------------------------------
> >  >  drivers/video/n411.c     |  202 +++++++++++++++++++++++++++++++++++++
> >  >  include/video/hecubafb.h |   51 +++++++++
> >  >  3 files changed, 304 insertions(+), 199 deletions(-)
> >
> >  Why is there no corresponding change to a Kconfig and Makefile?
> 
> I left the Kconfig/Makefile changes in patch 3. I am hoping that is

Ah, I didn't seem to have received that one...

> okay. Should I split those out?

I think it's better to keep the Kconfig/Makefile changes together. Else
you get an unbuildable tree if you apply patches 1-3, but don't apply
patch 4.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace