From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v2] [FB] Add the carmine FB driver. Date: Mon, 21 Apr 2008 13:12:00 +0200 (CEST) Message-ID: References: <20080421090124.GA11534@Chamillionaire.breakpoint.cc> <20080421101953.GB11534@Chamillionaire.breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JntwU-00042b-9P for linux-fbdev-devel@lists.sourceforge.net; Mon, 21 Apr 2008 04:12:14 -0700 Received: from harold.telenet-ops.be ([195.130.133.65]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1JntwR-000885-AP for linux-fbdev-devel@lists.sourceforge.net; Mon, 21 Apr 2008 04:12:14 -0700 In-Reply-To: <20080421101953.GB11534@Chamillionaire.breakpoint.cc> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Sebastian Siewior Cc: tglx@linutronix.de, linux-fbdev-devel@lists.sourceforge.net, Andrew Morton , Antonino Daplas On Mon, 21 Apr 2008, Sebastian Siewior wrote: > * Geert Uytterhoeven | 2008-04-21 11:55:56 [+0200]: > > >On Mon, 21 Apr 2008, Sebastian Siewior wrote: > >> +static int carmine_check_var(struct fb_var_screeninfo *var, > >> + struct fb_info *info) > >> +{ > >> + > >> + if (var->xres_virtual < var->xres) > >> + var->xres_virtual = var->xres; > >> + if (var->yres_virtual < var->yres) > >> + var->yres_virtual = var->yres; > >> + > >> + var->bits_per_pixel = 32; > >> + > >> +#ifdef __BIG_ENDIAN > >> + var->transp.offset = 24; > >> + var->red.offset = 0; > >> + var->green.offset = 8; > >> + var->blue.offset = 16; > >> +#else > >> + var->transp.offset = 24; > >> + var->red.offset = 16; > >> + var->green.offset = 8; > >> + var->blue.offset = 0; > >> +#endif > >> + > >> + var->red.length = 8; > >> + var->green.length = 8; > >> + var->blue.length = 8; > >> + var->transp.length = 8; > >> + > >> + var->red.msb_right = 0; > >> + var->green.msb_right = 0; > >> + var->blue.msb_right = 0; > >> + var->transp.msb_right = 0; > >> + > >> + return 0; > >> +} > > > >So carmine_check_var() always returns success, even if the user > >requested for a video mode that is not supported? > I though *var points to something that is from my carmine_modedb[]. No, it's the one you get from e.g. userspace. > >> +static int carmine_set_par(struct fb_info *info) > >> +{ > >> + struct carmine_fb *par = info->par; > >> + > >> + par->new_mode = carmine_find_mode(&info->var); > >> + > >> + if (par->cur_mode != par->new_mode) { > >> + > >> + par->cur_mode = par->new_mode; > >> + par->res = &car_modes[par->new_mode]; > >> + > >> + carmine_init_display_param(par); > >> + set_display_parameters(par); > >> + } > >> + > >> + info->fix.line_length = info->var.xres * info->var.bits_per_pixel / 8; > >> + return 0; > >> +} > > > >... in which case you just get the default mode, but info->var still > >contains the parameters for the mode that's not supported? > > Oh. Okey, so let me change carmine_check_var() and carmine_set_par() to > fail in case of an unsupported mode. Only carmine_check_var() has to check modes (and optionally round up modes that don't fit). carmine_set_par() will be called only if carmine_check_var() has succeeded. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone