Re: [PATCH] cirrusfb: use modedb and add mode_option parameter

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Sun, 31 Aug 2008, Krzysztof Helt wrote:
> On Sun, 31 Aug 2008 20:10:20 +0200 (CEST)
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Sun, 31 Aug 2008, Krzysztof Helt wrote:
> > > From: Krzysztof Helt <krzysztof.h1@wp.pl>
> > > 
> > > Use modedb for initial mode instead of a table
> > > of few predefined modes. Leave 640x480@60 mode
> > > in case the modedb failed.
> > 
> > Any specific reason you left the 640x480@60 mode?
> 
> I left the lowest one to have a safe setting in case the
> modedb does not match specified one.
> If you have a better way, let me know.

It's almost the same as the `640x480 @ 60 Hz, 31.5 kHz hsync' and the
`640x480-60 VESA' mode in the modedb, so I think it's safe to rely on
modedb only.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/