Re: [PATCH 1/4] cirrusfb: fix up debug printk types

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Sat, 6 Sep 2008, Krzysztof Helt wrote:
> On Sat, 6 Sep 2008 10:37:27 +0200 (CEST)
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Fri, 5 Sep 2008, Krzysztof Helt wrote:
> > > From: Krzysztof Helt <krzysztof.h1@wp.pl>
> > > 
> > > Fix debug printk types mismatch after
> > > my earlier changes.
> > 
> > #define DPRINTK(fmt, args...)	pr_debug("%s: " fmt, __func__ , ## args)
> > 
> > unconditionally, so you always catch these?
> > 
> 
> I do not understand. Is it a suggestion to make DPRINTK unconditional?

Yes.

> Then, the amount of information printed should be trimmed down. It is excessive now.

Please not that pr_debug() gets optimized away if DEBUG is not defined
( i.e. it doesn't cause excessive output), while it still performs
printf()-style format checking.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/