Re: Allow more revisions in epson s1d13... driver

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Mon, 29 Sep 2008, Thibaut VARENE wrote:
> On Mon, Sep 29, 2008 at 3:47 PM, Kristoffer Ericson
> <kristoffer.ericson@gmail.com> wrote:
> > I've been trying to get someones attention to this patch. Currently the
> > file in question is without maintainer.
> > Ive however talked to Author Thiabaut Varene and adapted according
> > to his suggestions (he's cc'ed in this mail).
> 
> This patch is a Ack from my side, save maybe for a tiny nitpick on the
> fact that I think s1d13xxxfb_revisions should be __devinitdata, but
> doing so seems to trigger compile issues. Haven't had time yet to dig
> that out.

> > +static const int s1d13xxxfb_revisions[] = {
> > +       S1D13506_CHIP_REV,/* Rev.4 on HP Jornada 7xx S1D13506 */
> > +       S1D13806_CHIP_REV /* Rev.7 on .. */
> > +};

Does the compile issue go away if you use __devinitconst instead of
__devinitdata?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/