From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [Linux-fbdev-devel] [PATCH] drivers: process failure of sysfs_create_group() Date: Mon, 10 Nov 2008 22:30:35 +0100 (CET) Message-ID: References: <20081110105332.GA19358@ubuntu> Mime-Version: 1.0 Return-path: In-Reply-To: <20081110105332.GA19358@ubuntu> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jianjun Kong Cc: spock@gentoo.org, linux-fbdev-devel@lists.sourceforge.net, Linux-Kernel-Mailing-List On Mon, 10 Nov 2008, Jianjun Kong wrote: > drivers: drivers/video/uvesafb.c: > When fail to call sysfs_create_group(), it should recycle resources and return the error. > This patch fix for processing failure of sysfs_create_group(). IIRC, the reasoning behind the current code is that a failure to create sysfs entries is not critical, as it doesn't impact the correct functioning of the core of the driver. > Signed-off-by: Jianjun Kong > --- > drivers/video/uvesafb.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c > index 6c2d37f..a78d4d9 100644 > --- a/drivers/video/uvesafb.c > +++ b/drivers/video/uvesafb.c > @@ -1811,12 +1811,16 @@ static int __devinit uvesafb_probe(struct platform_device *dev) > info->fix.id); > > err = sysfs_create_group(&dev->dev.kobj, &uvesafb_dev_attgrp); > - if (err != 0) > + if (err != 0) { > printk(KERN_WARNING "fb%d: failed to register attributes\n", > info->node); > + goto out_frame; > + } > > return 0; > > +our_frame: > + unregister_framebuffer(info); > out_reg: > release_region(0x3c0, 32); > out_unmap: Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds