From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>
Subject: fb_setcmap vs fb_setcolreg (was: Re: [PATCH] sh: sh7760fb: Fix color pallette setting)
Date: Fri, 21 Nov 2008 09:45:40 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0811210939380.12975@anakin> (raw)
In-Reply-To: <49264861.6030205@renesas.com>
On Fri, 21 Nov 2008, Nobuhiro Iwamatsu wrote:
> The setting of the color palette was wrong, fixed it.
> And removed fb_setcmap, and added fb_setcolreg function.
BTW, several drivers (radeonfb, omapfb, uvesafb, viafb) implement both
.fb_setcmap and .fb_setcolreg, which is a bit silly, as drivers/video/fbcmap.c
won't ever call .fb_setcolreg if .fb_setcmap is present.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
prev parent reply other threads:[~2008-11-21 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 5:35 [PATCH] sh: sh7760fb: Add support SH7720/SH7721 of Renesas Nobuhiro Iwamatsu
2008-11-21 5:34 ` [PATCH] sh: sh7760fb: Fix color pallette setting Nobuhiro Iwamatsu
2008-11-21 7:46 ` Paul Mundt
2008-11-21 8:45 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0811210939380.12975@anakin \
--to=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).