From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linux-fbdev-devel@lists.sourceforge.net,
linux-arm-kernel@lists.arm.linux.org.uk, adaplas@gmail.com
Subject: Re: [Linux-fbdev-devel] [PATCH 3/4 v5] i.MX31: framebuffer driver
Date: Tue, 23 Dec 2008 13:54:03 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0812231352390.17497@anakin> (raw)
In-Reply-To: <Pine.LNX.4.64.0812221929300.5241@axis700.grange>
On Mon, 22 Dec 2008, Guennadi Liakhovetski wrote:
> --- /dev/null
> +++ b/drivers/video/mx3fb.c
> @@ -0,0 +1,1853 @@
> +/**
> + * mx3fb_check_var() - check and adjust framebuffer variable parameters.
> + *
> + * @var: framebuffer variable parameters
> + * @fbi: framebuffer information pointer
> + */
> +static int mx3fb_check_var(struct fb_var_screeninfo *var, struct fb_info *fbi)
> +{
[...]
> + /* Copy nonstd field to/from sync for fbset usage */
> + var->sync |= var->nonstd;
> + var->nonstd |= var->sync;
What's the purpose of this (ab)use of .nonstd?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2008-12-23 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 18:31 [PATCH 0/4 v5] i.MX31: dmaengine and framebuffer drivers Guennadi Liakhovetski
2008-12-22 18:31 ` [PATCH 1/4 v5] dmaengine: add async_tx_clear_ack() macro Guennadi Liakhovetski
2008-12-22 18:31 ` [PATCH 2/4 v5] i.MX31: Image Processing Unit DMA and IRQ drivers Guennadi Liakhovetski
2008-12-22 18:32 ` [PATCH 3/4 v5] i.MX31: framebuffer driver Guennadi Liakhovetski
2008-12-23 12:54 ` Geert Uytterhoeven [this message]
2008-12-22 18:32 ` [PATCH 4/4 v5] i.MX31: platform bindings and initialisation for IPU and framebuffer drivers Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0812231352390.17497@anakin \
--to=geert@linux-m68k.org \
--cc=adaplas@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox