From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] fbdev: sh_mobile_lcdc: Turn dot clock on before resuming
Date: Tue, 12 Jul 2011 09:33:09 +0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1107121026050.18477@axis700.grange> (raw)
In-Reply-To: <1310387754-23033-1-git-send-email-laurent.pinchart@ideasonboard.com>
On Mon, 11 Jul 2011, Laurent Pinchart wrote:
> Resuming from runtime PM restores all LCDC registers. If the dot clock
> is off at that time display panning information will be corrupted.
>
> Turn the dot clock on before resuming from runtime PM. Similarly,
> turn the clock off after suspending the LCDC.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Damian Hobson-Garcia <dhobsong@igel.co.jp>
(testing would have been a bit easier, if prerequisites had been specified
in the patch;))
Tested-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks
Guennadi
> ---
> drivers/video/sh_mobile_lcdcfb.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> This patch should fix the LCDC panning issue caused by runtime suspend. It
> applies on top of Rafael J. Wysocki's pm-domains branch and Damian
> Hobson-Garcia's MERAM patches.
>
> diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c
> index 48a40e3..e9b80bc 100644
> --- a/drivers/video/sh_mobile_lcdcfb.c
> +++ b/drivers/video/sh_mobile_lcdcfb.c
> @@ -256,9 +256,9 @@ struct sh_mobile_lcdc_sys_bus_ops sh_mobile_lcdc_sys_bus_ops = {
> static void sh_mobile_lcdc_clk_on(struct sh_mobile_lcdc_priv *priv)
> {
> if (atomic_inc_and_test(&priv->hw_usecnt)) {
> - pm_runtime_get_sync(priv->dev);
> if (priv->dot_clk)
> clk_enable(priv->dot_clk);
> + pm_runtime_get_sync(priv->dev);
> if (priv->meram_dev && priv->meram_dev->pdev)
> pm_runtime_get_sync(&priv->meram_dev->pdev->dev);
> }
> @@ -267,11 +267,11 @@ static void sh_mobile_lcdc_clk_on(struct sh_mobile_lcdc_priv *priv)
> static void sh_mobile_lcdc_clk_off(struct sh_mobile_lcdc_priv *priv)
> {
> if (atomic_sub_return(1, &priv->hw_usecnt) = -1) {
> - if (priv->dot_clk)
> - clk_disable(priv->dot_clk);
> if (priv->meram_dev && priv->meram_dev->pdev)
> pm_runtime_put_sync(&priv->meram_dev->pdev->dev);
> pm_runtime_put(priv->dev);
> + if (priv->dot_clk)
> + clk_disable(priv->dot_clk);
> }
> }
>
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
next prev parent reply other threads:[~2011-07-12 9:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 12:35 [PATCH] fbdev: sh_mobile_lcdc: Turn dot clock on before resuming from runtime PM Laurent Pinchart
2011-07-12 9:33 ` Guennadi Liakhovetski [this message]
2011-07-12 9:37 ` Laurent Pinchart
2011-07-13 8:21 ` Paul Mundt
2011-09-20 19:30 ` Laurent Pinchart
2011-09-20 19:52 ` [PATCH] fbdev: sh_mobile_lcdc: Turn dot clock on before resuming Florian Tobias Schandinat
2011-09-20 19:56 ` [PATCH] fbdev: sh_mobile_lcdc: Turn dot clock on before resuming from runtime PM Laurent Pinchart
2011-09-20 20:19 ` [PATCH] fbdev: sh_mobile_lcdc: Turn dot clock on before resuming Florian Tobias Schandinat
2011-09-20 22:44 ` [PATCH] fbdev: sh_mobile_lcdc: Turn dot clock on before resuming from runtime PM Laurent Pinchart
2011-09-20 23:03 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1107121026050.18477@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox