* [PATCH] video: mx3fb: Use NULL for pointer
@ 2013-02-20 17:25 Fabio Estevam
2013-02-20 21:59 ` Guennadi Liakhovetski
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-02-20 17:25 UTC (permalink / raw)
To: linux-fbdev
From: Fabio Estevam <fabio.estevam@freescale.com>
Fix the following sparse error:
drivers/video/mx3fb.c:1309:28: warning: Using plain integer as NULL pointer
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/video/mx3fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
index 7368872..cfdb380 100644
--- a/drivers/video/mx3fb.c
+++ b/drivers/video/mx3fb.c
@@ -1306,7 +1306,7 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi)
dma_free_writecombine(fbi->device, fbi->fix.smem_len,
fbi->screen_base, fbi->fix.smem_start);
- fbi->screen_base = 0;
+ fbi->screen_base = NULL;
mutex_lock(&fbi->mm_lock);
fbi->fix.smem_start = 0;
fbi->fix.smem_len = 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: mx3fb: Use NULL for pointer
2013-02-20 17:25 [PATCH] video: mx3fb: Use NULL for pointer Fabio Estevam
@ 2013-02-20 21:59 ` Guennadi Liakhovetski
0 siblings, 0 replies; 2+ messages in thread
From: Guennadi Liakhovetski @ 2013-02-20 21:59 UTC (permalink / raw)
To: linux-fbdev
On Wed, 20 Feb 2013, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Fix the following sparse error:
>
> drivers/video/mx3fb.c:1309:28: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks
Guennadi
> ---
> drivers/video/mx3fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
> index 7368872..cfdb380 100644
> --- a/drivers/video/mx3fb.c
> +++ b/drivers/video/mx3fb.c
> @@ -1306,7 +1306,7 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi)
> dma_free_writecombine(fbi->device, fbi->fix.smem_len,
> fbi->screen_base, fbi->fix.smem_start);
>
> - fbi->screen_base = 0;
> + fbi->screen_base = NULL;
> mutex_lock(&fbi->mm_lock);
> fbi->fix.smem_start = 0;
> fbi->fix.smem_len = 0;
> --
> 1.7.9.5
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-20 21:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-20 17:25 [PATCH] video: mx3fb: Use NULL for pointer Fabio Estevam
2013-02-20 21:59 ` Guennadi Liakhovetski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).