From: Jim Hague <jim.hague@acm.org>
To: linux-fbdev-devel@lists.sourceforge.net,
Antonino Daplas <adaplas@pol.net>, Andrew Morton <akpm@osdl.org>
Cc: Ron Murray <murrayr@dor.state.ma.us>
Subject: Re: [PATCH 4/4] pm2fb: fix big-endian (Sparc) support
Date: Tue, 07 Dec 2004 13:35:51 -0000 (GMT) [thread overview]
Message-ID: <XFMail.20041207133551.jim.hague@acm.org> (raw)
In-Reply-To: <20041207115034.4b16ad01@hagrid.bear-cave.org.uk>
On 07-Dec-2004 Jim Hague wrote:
> - Big-endian fixes. The driver is now known to work on Sparc.
That's a crap patch description. Sorry. Let's try again:
A collection of changes that taken together makes the driver work correctly on
big-endian systems, specifically Sparc.
- Remove old PM2FB_BE_APERTURE define and use __BIG_ENDIAN
throughout. PM2FB_BE_APERTURE wasn't defined on Sparc; this
was incorrect.
- Replace colour mode magic numbers with suitable constants,
and tidy colour mode handling. Use BGR not RGB at 24bit on
big-endian.
- Replace aperture magic numbers with constants. Rearrange code to
emphasise second aperture is not used. Add short explanations
of aperture settings for big endian.
- Update comments to note that the driver now works on Sparc.
- Revisit 32bit depth colour offsets and ensure transp is set.
--
Jim Hague - jim.hague@acm.org Never trust a computer you can't lift.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
prev parent reply other threads:[~2004-12-07 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-07 11:50 [PATCH 4/4] pm2fb: fix big-endian (Sparc) support Jim Hague
2004-12-07 13:35 ` Jim Hague [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=XFMail.20041207133551.jim.hague@acm.org \
--to=jim.hague@acm.org \
--cc=adaplas@pol.net \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=murrayr@dor.state.ma.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).