From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEF90C3DA7A for ; Fri, 6 Jan 2023 17:43:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232530AbjAFRnw (ORCPT ); Fri, 6 Jan 2023 12:43:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232399AbjAFRnr (ORCPT ); Fri, 6 Jan 2023 12:43:47 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C4B67F475 for ; Fri, 6 Jan 2023 09:43:41 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id l26so1553412wme.5 for ; Fri, 06 Jan 2023 09:43:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=91SF8VEv5OWfr7BVQVJeS0qUaBJRLWmE1paTtWSlkNk=; b=F5S5LtEkn6UpgyK4ZdRqG7PREzFRkWFR9ntEYFZEYkYrWO19F3t1G1UkA1mfzFV3+1 ZNHtbDmVCdb8JLPvY4KgNQkYtM/vKK/FiseLqJnecrhGdyYNUkr9hR6elGwZUv/rOVDr uZGA75rjYhoa7IAsBRIa4gB/l5/iceCceQUNo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=91SF8VEv5OWfr7BVQVJeS0qUaBJRLWmE1paTtWSlkNk=; b=I8NdtgskPcPOcPrKKrTKuz0lj6Fiz4H7fv8DG+TM6eaLUItiE61p42rc77pUdbKcXf +5zDugiRvLvM5/6eP8BRHgi2KpeBc93xup4ON4i32xw4PJgQh9QN8V+2ZjF1XlKVJle7 UGnXESFfbHGJphg2fEqKYIIlVdCmoqpNwGnnb25p3Gw9NfwRTJJa8Qgy6/xe9Qi1I3kg Vz//OPcNZydwvQwxKvGqwvgswRDwtU1bhT1G48GnhZ7TWemLyHOs3X4V5UaF2lgc6Jju LT8pY7orotJXZZfVydRowWbsTceQ6/iKg9Y8cfl2Y0OXPyhExedGtKWilsGld/1t4Yu5 yKWw== X-Gm-Message-State: AFqh2kqbrctTgSdE2p2BqfvVAeLAjJmVe5cRDUhzy5I9DBDYL+m5l9Fa zf4+/3RbAUg+PKjvBBaS/O5xyA== X-Google-Smtp-Source: AMrXdXtSD1W10kYYcsrjXwJcPhNZEFjWcjAy7xGKIyGWPq4m1U5ZvRhIKWL3HO3EVrZrvCXXngfYEA== X-Received: by 2002:a05:600c:1d03:b0:3d3:4aa6:4fe6 with SMTP id l3-20020a05600c1d0300b003d34aa64fe6mr38928152wms.3.1673027019752; Fri, 06 Jan 2023 09:43:39 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h15-20020a05600c314f00b003d99469ece1sm7543346wmo.24.2023.01.06.09.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 09:43:38 -0800 (PST) Date: Fri, 6 Jan 2023 18:43:36 +0100 From: Daniel Vetter To: Stephen Kitt Cc: Lee Jones , Daniel Thompson , Jingoo Han , linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sam Ravnborg Subject: Re: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper Message-ID: Mail-Followup-To: Stephen Kitt , Lee Jones , Daniel Thompson , Jingoo Han , linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sam Ravnborg References: <20230106164856.1453819-2-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230106164856.1453819-2-steve@sk2.org> X-Operating-System: Linux phenom 5.19.0-2-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Fri, Jan 06, 2023 at 05:48:52PM +0100, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt Lee/Daniel, will you pick these up, or should I smash them all into drm-misc-next for 6.3? Stephen, I see to be missing 3/4 here, but maybe it'll show up. -Daniel > --- > drivers/video/backlight/aat2870_bl.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/video/backlight/aat2870_bl.c b/drivers/video/backlight/aat2870_bl.c > index a7af9adafad6..1cbb303e9c88 100644 > --- a/drivers/video/backlight/aat2870_bl.c > +++ b/drivers/video/backlight/aat2870_bl.c > @@ -59,7 +59,7 @@ static int aat2870_bl_update_status(struct backlight_device *bd) > struct aat2870_bl_driver_data *aat2870_bl = bl_get_data(bd); > struct aat2870_data *aat2870 = > dev_get_drvdata(aat2870_bl->pdev->dev.parent); > - int brightness = bd->props.brightness; > + int brightness = backlight_get_brightness(bd); > int ret; > > if ((brightness < 0) || (bd->props.max_brightness < brightness)) { > @@ -70,11 +70,6 @@ static int aat2870_bl_update_status(struct backlight_device *bd) > dev_dbg(&bd->dev, "brightness=%d, power=%d, state=%d\n", > bd->props.brightness, bd->props.power, bd->props.state); > > - if ((bd->props.power != FB_BLANK_UNBLANK) || > - (bd->props.state & BL_CORE_FBBLANK) || > - (bd->props.state & BL_CORE_SUSPENDED)) > - brightness = 0; > - > ret = aat2870->write(aat2870, AAT2870_BLM, > (u8)aat2870_brightness(aat2870_bl, brightness)); > if (ret < 0) > -- > 2.30.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch