From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AC22C67871 for ; Mon, 9 Jan 2023 18:24:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237062AbjAISXs (ORCPT ); Mon, 9 Jan 2023 13:23:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237590AbjAISXF (ORCPT ); Mon, 9 Jan 2023 13:23:05 -0500 Received: from mailrelay4-1.pub.mailoutpod2-cph3.one.com (mailrelay4-1.pub.mailoutpod2-cph3.one.com [46.30.211.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99ECE13F7C for ; Mon, 9 Jan 2023 10:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=xr+iUWmfOB1CLBr6Qsy2YZMDRotm12WBZ/zh+3qIGnqD+WW38gq16Rl6LS9taWAIgXP2llv2ueyF0 fA3iIIxYnmuPGkwiK+SGk3l7yHRvIxggcTtT7x2q0+wwF6fVIQkEzPtcW04Q4A6X4SKS9m56vo7D0o hLzfG7GraTS31Ch8FAtoGue7T76SmYvTnNeZNZkj0/5oK6YNNivj7Wo0ExtjbmvCmHRBteAPdkj/Eg NkDkGI6lGIPAVh39LbMkR8Ej5M2GsnANIVRaeRashpzz54gdLod6v1ri7V6JrPjvdhVHIVaCwftjs+ 2rttIhFTMoveJDSDeM23dX3GpjUJUVw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=nxcQ2DNweooGl9o3PknXxmGKMXudrM7A8yocezPtlLEgBpQEu7WtSwjxUTWj2HhN7+D5H3vtKKz4P oB6b4GmAA== X-HalOne-ID: 5e23647e-904a-11ed-85ce-87783a957ad9 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay4 (Halon) with ESMTPSA id 5e23647e-904a-11ed-85ce-87783a957ad9; Mon, 09 Jan 2023 18:21:02 +0000 (UTC) Date: Mon, 9 Jan 2023 19:21:00 +0100 From: Sam Ravnborg To: Christophe Leroy Cc: Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han , "linux-fbdev@vger.kernel.org" , Stephen Kitt , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Jani Nikula , "linux-staging@lists.linux.dev" , Maarten Lankhorst , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Jason Yan , Souptick Joarder , Daniel Vetter , "linux-omap@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness() Message-ID: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-2-1bd9bafb351f@ravnborg.org> <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Christophe, On Mon, Jan 09, 2023 at 05:44:46PM +0000, Christophe Leroy wrote: > > > Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit : > > From: Sam Ravnborg > > > > Introduce backlight_get_brightness() to simplify logic > > and avoid direct access to backlight properties. > > When I read 'introduce' I understand that you are adding a new function. > > In fact backlight_get_brightness() already exists, so maybe replace > 'introduce' by 'use' Thanks for your feedback. A similar patch is already applied to the fbdev tree, so this patch can be ignored. Sam