From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CDADC677F1 for ; Tue, 17 Jan 2023 14:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232091AbjAQOkm (ORCPT ); Tue, 17 Jan 2023 09:40:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232030AbjAQOkk (ORCPT ); Tue, 17 Jan 2023 09:40:40 -0500 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B475918AA8; Tue, 17 Jan 2023 06:40:39 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id 200so17449865pfx.7; Tue, 17 Jan 2023 06:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qcroq+mFKouwR+/bBpeFk/JR29GbAoQBqgOKbzIUZz8=; b=KBb5N8zYdxuggewHiXhsxRiZVIOD9Fr9jOyo32rvBUdVRSqNydT2Khr8abDEPHnuSq mElzI9wE0/mwb/MTnoWq4eyGRaNkGfzt/qiIfOTVHY+yhS8/G29Sbfh70frKViB4AxpQ vcI5mGaRlnpDtxcqAub0Ebe8Sj28y0d2iTf037VoFOnf5XueOSxKTqbinx8pwmDhsk7W v7NEly7UxoQd61gTbduNmMQURPV1BpQtrby4HiOmUWbMkCJvT48LQ68RaZm/cYwVeDSB C2wHlQ6ODedwu+Wmdewm/QLuW1GbTS9zV/I2UoiyoYUvopdhZAorSCi1wGg/hAv8gEQ9 LfTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qcroq+mFKouwR+/bBpeFk/JR29GbAoQBqgOKbzIUZz8=; b=dcQGECQOJE40Mrwg01gyk+oq9cjeKgu27fKn+pYBSrs3kB7xyjp678KgxO6X3YUKAP edDDpxG+zlFTAwmtOq8a0M7Sc+ezgMqTm4HEpLl5kwaX2InDSAwdiDe6CdWRLH53Di2W CdIxM7Y5v2eDRyGLRnjWODQqI/sjhEHpPMJZgkEAWBWnBxL4v0TgTt2JqUyM4W50UWn8 rP8Il6xW+MdpJkoRkR9A8d4IgLx2bAA6YHPbfhYK9mlKo7VU3o9s26sGmCUMDUK9zCzR ClzKqZWOvhWwEBDk3l9C7h8nDtmiJTHUYiRBi9wlxuXUHPbuver7EmNHMpkCOpSrECE8 FLUg== X-Gm-Message-State: AFqh2kpT2QFF4ks4PEOBi1ty6AGrlsKW0/z8OLFVEVAXwYeVXACeTv0U GHqrqG6zmAEpsb+kxK+uVOI= X-Google-Smtp-Source: AMrXdXvZcqeSg776royCMr06wK9DVvJMlFYwnqI++6eoDr9NvUqlrsqJrfDMHoofhTwjeZQXFQLQGg== X-Received: by 2002:a62:830d:0:b0:58d:94f4:a8b9 with SMTP id h13-20020a62830d000000b0058d94f4a8b9mr4100349pfe.11.1673966439212; Tue, 17 Jan 2023 06:40:39 -0800 (PST) Received: from Gentoo (n220246252084.netvigator.com. [220.246.252.84]) by smtp.gmail.com with ESMTPSA id z30-20020aa7991e000000b005898fcb7c2bsm15800827pff.170.2023.01.17.06.40.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 06:40:38 -0800 (PST) Date: Tue, 17 Jan 2023 22:40:31 +0800 From: Jianhua Lu To: Daniel Thompson Cc: Lee Jones , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v4 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight Message-ID: References: <20230117134742.23238-1-lujianhua000@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Tue, Jan 17, 2023 at 02:37:07PM +0000, Daniel Thompson wrote: > On Tue, Jan 17, 2023 at 10:12:18PM +0800, Jianhua Lu wrote: > > On Tue, Jan 17, 2023 at 02:04:05PM +0000, Daniel Thompson wrote: > > > On Tue, Jan 17, 2023 at 09:47:41PM +0800, Jianhua Lu wrote: > > > > Add support for Kinetic KTZ8866 backlight, which is used in > > > > Xiaomi tablet, Mi Pad 5 series. This driver lightly based on > > > > downstream implementation [1]. > > > > [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c > > > > > > > > Signed-off-by: Jianhua Lu > > > > --- > > > > Changes in v2: > > > > - Add missing staitc modifier to ktz8866_write function. > > > > > > > > Changes in v3: > > > > - Add 2022 to Copyright line. > > > > - Sort headers. > > > > - Remove meaningless comment. > > > > - Use definitions instead of hardcoding. > > > > - Add missing maintainer info. > > > > > > > > Changes in v4: > > > > - Change 2022 to 2023. > > > > - Remove useless macro and enum. > > > > - Describe settings by devicetree. > > > > - Move header file to C file. > > > > > > > > MAINTAINERS | 6 + > > > > drivers/video/backlight/Kconfig | 8 ++ > > > > drivers/video/backlight/Makefile | 1 + > > > > drivers/video/backlight/ktz8866.c | 195 ++++++++++++++++++++++++++++++ > > > > 4 files changed, 210 insertions(+) > > > > create mode 100644 drivers/video/backlight/ktz8866.c > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > index 42fc47c6edfd..2084e74e1b58 100644 > > > > --- a/MAINTAINERS > > > > +++ b/MAINTAINERS > > > > @@ -11674,6 +11674,12 @@ M: John Hawley > > > > S: Maintained > > > > F: tools/testing/ktest > > > > > > > > +KTZ8866 BACKLIGHT DRIVER > > > > +M: Jianhua Lu > > > > +S: Maintained > > > > +F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > > > > +F: drivers/video/backlight/ktz8866.c > > > > + > > > > L3MDEV > > > > M: David Ahern > > > > L: netdev@vger.kernel.org > > > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > > > > index 936ba1e4d35e..2845fd7e33ad 100644 > > > > --- a/drivers/video/backlight/Kconfig > > > > +++ b/drivers/video/backlight/Kconfig > > > > @@ -190,6 +190,14 @@ config BACKLIGHT_KTD253 > > > > which is a 1-wire GPIO-controlled backlight found in some mobile > > > > phones. > > > > > > > > +config BACKLIGHT_KTZ8866 > > > > + tristate "Backlight Driver for Kinetic KTZ8866" > > > > + depends on I2C > > > > + select REGMAP_I2C > > > > + help > > > > + Say Y to enabled the backlight driver for the Kinetic KTZ8866 > > > > + found in Xiaomi Mi Pad 5 series. > > > > + > > > > config BACKLIGHT_LM3533 > > > > tristate "Backlight Driver for LM3533" > > > > depends on MFD_LM3533 > > > > diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Makefile > > > > index e815f3f1deff..f70a819c304c 100644 > > > > --- a/drivers/video/backlight/Makefile > > > > +++ b/drivers/video/backlight/Makefile > > > > @@ -36,6 +36,7 @@ obj-$(CONFIG_BACKLIGHT_HP680) += hp680_bl.o > > > > obj-$(CONFIG_BACKLIGHT_HP700) += jornada720_bl.o > > > > obj-$(CONFIG_BACKLIGHT_IPAQ_MICRO) += ipaq_micro_bl.o > > > > obj-$(CONFIG_BACKLIGHT_KTD253) += ktd253-backlight.o > > > > +obj-$(CONFIG_BACKLIGHT_KTZ8866) += ktz8866.o > > > > obj-$(CONFIG_BACKLIGHT_LM3533) += lm3533_bl.o > > > > obj-$(CONFIG_BACKLIGHT_LM3630A) += lm3630a_bl.o > > > > obj-$(CONFIG_BACKLIGHT_LM3639) += lm3639_bl.o > > > > diff --git a/drivers/video/backlight/ktz8866.c b/drivers/video/backlight/ktz8866.c > > > > new file mode 100644 > > > > index 000000000000..98916f92d069 > > > > --- /dev/null > > > > +++ b/drivers/video/backlight/ktz8866.c > > > > @@ -0,0 +1,195 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-only > > > > +/* > > > > + * Backlight driver for the Kinetic KTZ8866 > > > > + * > > > > + * Copyright (C) 2023 Jianhua Lu > > > > > > Shouldn't this be: > > > Copyright (C) 2022, 2023 Jianhua Lu > > > > > > > +static int ktz8866_probe(struct i2c_client *client, > > > > + const struct i2c_device_id *id) > > > > +{ > > > > + struct backlight_device *backlight_dev; > > > > + struct backlight_properties props; > > > > + struct ktz8866 *ktz; > > > > + > > > > + ktz = devm_kzalloc(&client->dev, sizeof(*ktz), GFP_KERNEL); > > > > + if (!ktz) > > > > + return -ENOMEM; > > > > + > > > > + ktz->client = client; > > > > + ktz->regmap = devm_regmap_init_i2c(client, &ktz8866_regmap_config); > > > > + > > > > + if (IS_ERR(ktz->regmap)) { > > > > + dev_err(&client->dev, "failed to init regmap\n"); > > > > + return PTR_ERR(ktz->regmap); > > > > + } > > > > + > > > > + memset(&props, 0, sizeof(props)); > > > > + props.type = BACKLIGHT_RAW; > > > > + props.max_brightness = MAX_BRIGHTNESS; > > > > + props.brightness = DEFAULT_BRIGHTNESS; > > > > > > There is still pending feedback from v3. > > > > > > | Please set the scale property correctly. "Unknown" is never correct for > > > | new drivers. > > Do you means backlight_properties.backlight_scale? > > props.scale = BACKLIGHT_SCALE_; > > (the memset means you are currently setting the scale to > BACKLIGHT_SCALE_UNKNOWN ) Thanks for explanation. > > > Daniel.