From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
linux-fbdev@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] video: backlight: ili9320: Make ili9320_remove() return void
Date: Wed, 20 Oct 2021 15:14:13 +0100 [thread overview]
Message-ID: <YXAkNUrm2QI2XNyo@google.com> (raw)
In-Reply-To: <20211019120927.3822792-1-u.kleine-koenig@pengutronix.de>
On Tue, 19 Oct 2021, Uwe Kleine-König wrote:
> Up to now ili9320_remove() returns zero unconditionally. Make it return
> void instead which makes it easier to see in the callers that there is
> no error to handle.
>
> Also the return value of spi remove callbacks is ignored anyway.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/video/backlight/ili9320.c | 3 +--
> drivers/video/backlight/ili9320.h | 2 +-
> drivers/video/backlight/vgg2432a4.c | 4 +++-
> 3 files changed, 5 insertions(+), 4 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-10-20 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 12:09 [PATCH] video: backlight: ili9320: Make ili9320_remove() return void Uwe Kleine-König
2021-10-19 15:30 ` Daniel Thompson
2021-10-19 16:36 ` Uwe Kleine-König
2021-10-20 13:32 ` Daniel Thompson
2021-10-20 14:14 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXAkNUrm2QI2XNyo@google.com \
--to=lee.jones@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).