From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1BB2C433F5 for ; Thu, 27 Jan 2022 11:11:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235651AbiA0LLK (ORCPT ); Thu, 27 Jan 2022 06:11:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231377AbiA0LLJ (ORCPT ); Thu, 27 Jan 2022 06:11:09 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7409CC06173B for ; Thu, 27 Jan 2022 03:11:09 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id u15so4101997wrt.3 for ; Thu, 27 Jan 2022 03:11:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=Q+ftSI0F0/Im74lDzb4er70a9ByF00QgQAuRt8psbLQ=; b=N5Fa1T8zfl0y2EjCaDtDX+8dseudhqkFzw/Vi14SNkB/atAy/QGQLlf19t0nUpYRXr P1n7AE9R37LW3Tfm/a1TXW86YKv6K0YNFmg/DKnf7HQuFb2VSyOSFbrWcYaDPgeK3yYe Uz2bykGO2FQD/+wh8ZoTsqjM+kiTtXY4KplsI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=Q+ftSI0F0/Im74lDzb4er70a9ByF00QgQAuRt8psbLQ=; b=qT8jCk/cttdcYymownwjZ71kjYys9CwbU8WKiDpo62/k/zUQDpqWfDEMy/tLTmGz2R cpZGJG0dz/W2x3A8eSK2f80TJ2Z25tTFN3uJVd+j5xI4ZHOHUcG+3IW629lGcR+8/NqQ UhU9MTJtvkIzcmrphV5UKeKJmxAPlxTbOD0tqr1o/1QrOcRqXwN0y4MkHCqOafSjgNo4 C0Icr0w6eFISBgQppyRsj3fmYFsdm9+sEXgL2o0LGvttPrFRsBuv8Spt5M0+zfStaePn ge7/cK6m1USJQzl9xp2RZ6zJchkZgHJA1Ij0/+8oZIoBOX2Rem9SJg0Ucft6lA3trZ5n xt6w== X-Gm-Message-State: AOAM532xQ1pM3O/5P+0sPksA4lmRxIKKdmZyb2JgOmDQqBG0efDsfn3U Y0IT/TRL6C33Iq5YlL9TPKELKg== X-Google-Smtp-Source: ABdhPJwAFil42wR4BzzRzMkyK3qxmmts6cgadNUMSsg5Myn0J+D62I0vtwRvYDkdPdH775qoOOP+Tg== X-Received: by 2002:a05:6000:1203:: with SMTP id e3mr2565698wrx.221.1643281868064; Thu, 27 Jan 2022 03:11:08 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id w8sm1873068wrq.3.2022.01.27.03.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jan 2022 03:11:07 -0800 (PST) Date: Thu, 27 Jan 2022 12:11:05 +0100 From: Daniel Vetter To: Dmitry Vyukov Cc: Dan Carpenter , Daniel Vetter , syzkaller-bugs , Greg Kroah-Hartman , Andy Shevchenko , linux-fbdev@vger.kernel.org, Michael Hennerich , Helge Deller , linux-staging@lists.linux.dev, Javier Martinez Canillas , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Thomas Zimmermann , Carlis , Phillip Potter , Lee Jones , Heiner Kallweit , syzkaller Subject: Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance Message-ID: Mail-Followup-To: Dmitry Vyukov , Dan Carpenter , syzkaller-bugs , Greg Kroah-Hartman , Andy Shevchenko , linux-fbdev@vger.kernel.org, Michael Hennerich , Helge Deller , linux-staging@lists.linux.dev, Javier Martinez Canillas , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Thomas Zimmermann , Carlis , Phillip Potter , Lee Jones , Heiner Kallweit , syzkaller References: <3430838d-1c63-da49-b774-c5a883e7085f@redhat.com> <20220126144524.GB1951@kadam> <20220127062945.GC1951@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Thu, Jan 27, 2022 at 11:32:58AM +0100, Dmitry Vyukov wrote: > On Thu, 27 Jan 2022 at 07:30, Dan Carpenter wrote: > > > > On Wed, Jan 26, 2022 at 11:31:02PM +0100, Daniel Vetter wrote: > > > dOn Wed, Jan 26, 2022 at 3:46 PM Dan Carpenter wrote: > > > > > > > > The other advantage of staging is the I don't think syzbot enables it. > > > > I guess it's easier to persuade Dmitry to ignore STAGING than it was to > > > > get him to disable FBDEV. :P > > > > > > > > The memory corruption in fbdev was a real headache for everyone because > > > > the stack traces ended up all over the kernel. > > > > > > Uh Dmitry disabled all of FBDEV? > > > > No that's the opposite of what I meant. STAGING is disabled in syzbot > > and FBDEV is enabled. > > Is there still any problem with syzbot config? > syzbot configs are stored here: > https://github.com/google/syzkaller/tree/master/dashboard/config/linux CONFIG_FB and CONFIG_FRAMEBUFFER_CONSOLE are set, which are the things I care about. The one exception is upstream-kcsan.config, which doesn't have fbcon enabled. Also looking through your fbdev drivers, really the only ones you want to ever enable are: CONFIG_FB_VGA16=y CONFIG_FB_VESA=y CONFIG_FB_VIRTUAL=y The following isn't enabled, but I guess if you don't have EFI doesn't make sense, otherwise you really want it: CONFIG_FB_EFI=y The below are enabled in some configs and should be ditched CONFIG_FB_SIMPLE=y (use CONFIG_DRM_SIMPLEDRM instead, at least on kernels that have it) CONFIG_FB_I740=y (you don't have this hw or I'm blown away, this last shipped 20 years ago) CONFIG_FB_UDL=y (use CONFIG_DRM_UDL instead) CONFIG_FB_UVESA=y (does modesets by calling into a userspace helper to run x86 vbios code, just don't) CONFIG_FB_SMSCUFX=y (if you really have these then someone should port this to drm asap) CONFIG_FB_CIRRUS=y (use CONFIG_DRM_CIRRUS_QEMU instead since I'm pretty sure you don't have a real cirrus pci card) Also note that the simpledrm driver will eat all the firmware fbdev drivers and unload them. So you need to run two configs to really cover both sets of drivers in all cases. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch