From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE926C433F5 for ; Tue, 8 Feb 2022 18:22:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231478AbiBHSWJ (ORCPT ); Tue, 8 Feb 2022 13:22:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384530AbiBHSWI (ORCPT ); Tue, 8 Feb 2022 13:22:08 -0500 Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F16AC061578 for ; Tue, 8 Feb 2022 10:22:07 -0800 (PST) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 2ab33094-890c-11ec-ac19-0050568cd888; Tue, 08 Feb 2022 18:23:09 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 0133D194BAE; Tue, 8 Feb 2022 19:22:05 +0100 (CET) Date: Tue, 8 Feb 2022 19:22:03 +0100 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: DRI Development , linux-fbdev@vger.kernel.org, Intel Graphics Development , LKML , Daniel Vetter , Helge Deller Subject: Re: [PATCH 10/21] fb: Delete fb_info->queue Message-ID: References: <20220131210552.482606-1-daniel.vetter@ffwll.ch> <20220131210552.482606-11-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Daniel, On Tue, Feb 08, 2022 at 02:46:33PM +0100, Daniel Vetter wrote: > On Thu, Feb 03, 2022 at 10:31:00PM +0100, Sam Ravnborg wrote: > > On Mon, Jan 31, 2022 at 10:05:41PM +0100, Daniel Vetter wrote: > > > It was only used by fbcon, and that now switched to its own, > > > private work. > > > > > > Signed-off-by: Daniel Vetter > > > Cc: Helge Deller > > > Cc: linux-fbdev@vger.kernel.org > > I would merge this with the patch that drops the usage > > Yeah, but I like to split these out so that if this does break something, > it's much easier to revert. In case I overlooked something somewhere. > > It's imo different if the cleanup is directly related to the preceeding > prep work, but this is a generic workqueue, and the cursor logic is rather > unrelated. And if I remember my history digging right, there were actually > other uses of this. So you basically say that because in the past there may have been other users, this deserves a dedicated removal commit. That works for me too. Acked-by: Sam Ravnborg Sam