From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ACF2C433EF for ; Tue, 8 Feb 2022 22:23:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386245AbiBHWXp (ORCPT ); Tue, 8 Feb 2022 17:23:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386626AbiBHU7i (ORCPT ); Tue, 8 Feb 2022 15:59:38 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6D8EC0612C3 for ; Tue, 8 Feb 2022 12:59:37 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id i15so574578wrb.3 for ; Tue, 08 Feb 2022 12:59:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=LR/HqP2Q1P8BmgSmBhLwoCgWv4OeRLxaaKVnBHVz380=; b=OClWzaHwfnKbU2ivv9C7fQtoAaSQhJdGklXpEzcFffm1SkumsQsTkr8ZOu//Qj3wMX gEbDIlvZmGBGIRp32EXuJUt4pdkA+9hSevTsMS5kH+0eK7Qp5AnE8d5EBZDnA9LbvTcn umgHa0cvz5UESKxYpoHkM5AGiSPrp+EXDnSms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=LR/HqP2Q1P8BmgSmBhLwoCgWv4OeRLxaaKVnBHVz380=; b=Tuw7EahOB00xSOkADeCT9G7vqUwjagttxbMZDV4vG+pKjWa+D4D/i0UseqkP4uKtOa 3iqfetQvJqo15B80HmVfUKVC/YcZ01vn4q63gzMS6O0h8e4Xojhe0xRKFAYw2TTEFWVJ YA9dU5dppICparoZUOD9bI+A/qKm76U39ssHqVTTcbtD+J/Mv+GzqT93XnDPtXzmIIHR Wp6jzP2cupmXoyhfoG9IC+YkVULIZLZmcowhZUy47QSZOJTr+fmUs37r+K2eScFto2fz VbOyGBg0oK+ScbVjtM1jEnAnmAP3Obcq4KIurK8GipJRd6eJD3Ic03dZQqraTQHUPzUq brlw== X-Gm-Message-State: AOAM531/0QwCRdheRiuGvvlJnJCk/KH7u+CzoIIKVPYItzjGJCD6A6np 6iDzijPI+yHf43bCflZnwrinQQ== X-Google-Smtp-Source: ABdhPJyoKyE7ZSiQIZzA82zoDzmj1UBV8TCrGt8kooKo8r1vgxpn3G6jb5XrdBUZcozMC7B14dmZJA== X-Received: by 2002:a5d:64c8:: with SMTP id f8mr5121045wri.337.1644353976273; Tue, 08 Feb 2022 12:59:36 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id e3sm7852138wrr.94.2022.02.08.12.59.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 12:59:35 -0800 (PST) Date: Tue, 8 Feb 2022 21:59:33 +0100 From: Daniel Vetter To: Geert Uytterhoeven , DRI Development , Intel Graphics Development , Linux Fbdev development list , LKML , Jens Frederich , Jon Nettleton , Greg Kroah-Hartman , linux-staging@lists.linux.dev, Daniel Vetter , Helge Deller , Matthew Wilcox , Sam Ravnborg , Tetsuo Handa , Zhen Lei , Alex Deucher , Xiyu Yang , Zheyu Ma , Guenter Roeck Subject: Re: [PATCH 21/21] fbdev: Make registered_fb[] private to fbmem.c Message-ID: Mail-Followup-To: Geert Uytterhoeven , DRI Development , Intel Graphics Development , Linux Fbdev development list , LKML , Jens Frederich , Jon Nettleton , Greg Kroah-Hartman , linux-staging@lists.linux.dev, Daniel Vetter , Helge Deller , Matthew Wilcox , Sam Ravnborg , Tetsuo Handa , Zhen Lei , Alex Deucher , Xiyu Yang , Zheyu Ma , Guenter Roeck References: <20220131210552.482606-1-daniel.vetter@ffwll.ch> <20220131210552.482606-22-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Tue, Feb 08, 2022 at 03:04:51PM +0100, Daniel Vetter wrote: > On Fri, Feb 04, 2022 at 09:30:56AM +0100, Geert Uytterhoeven wrote: > > Hi Daniel, > > > > Thanks for your patch! > > > > On Tue, Feb 1, 2022 at 9:50 PM Daniel Vetter wrote: > > > Well except when the olpc dcon fbdev driver is enabled, that thing > > > digs around in there in rather unfixable ways. > > > > Can't the actual frame buffer driver (which one?) used on olpc export > > a pointer to its fb_info? > > Yeah that might be the right thing to do, I'll add that as a stagin TODO > in the next iteration. Well I tried to do that and noticed I've done that already in 2019: commit af1440368837f19ac7d5dec05d929d91308f5a90 Author: Daniel Vetter Date: Tue May 28 11:03:03 2019 +0200 staging/olpc_dcon: Add drm conversion to TODO TODO already explains how this should be done correctly in drm. Well maybe we should add that stitching the drivers together should be done with component.c or something like that. -Daniel > > > > > > --- a/drivers/video/fbdev/core/fbmem.c > > > +++ b/drivers/video/fbdev/core/fbmem.c > > > @@ -48,10 +48,14 @@ > > > static DEFINE_MUTEX(registration_lock); > > > > > > struct fb_info *registered_fb[FB_MAX] __read_mostly; > > > -EXPORT_SYMBOL(registered_fb); > > > - > > > int num_registered_fb __read_mostly; > > > +#if IS_ENABLED(CONFIG_OLPC_DCON) > > > > CONFIG_FB_OLPC_DCON (everywhere), cfr. the build failure reported > > by the robot. > > Yeah realized that too and fixed it locally. > > Cheers, Daniel > > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > > > In personal conversations with technical people, I call myself a hacker. But > > when I'm talking to journalists I just say "programmer" or something like that. > > -- Linus Torvalds > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch