From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EACCFC433EF for ; Wed, 9 Feb 2022 16:41:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237411AbiBIQlZ (ORCPT ); Wed, 9 Feb 2022 11:41:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237397AbiBIQlY (ORCPT ); Wed, 9 Feb 2022 11:41:24 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D285C05CB8E; Wed, 9 Feb 2022 08:41:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644424884; x=1675960884; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=r9L2ApNXksnGqO8AjDsuLj/L+RaApKpFYz722Z9aqx4=; b=n0X+kD9aFzQkzbxN1rb8OKL3uK5VoIejB1X9LewuF9jCRbUE1mX9ltoS FzLVkfY93xVH0he898WHFEKIE33KgZnXp0xV4z17CXoam7ao+SL/Blzlv c3RpMEIDn5sL9MmuTXwR6LYZw7OvGplCtCbLY8zajjE6WuZ3iez495fTl yuCaNxrN0xsZU1/lOik5wnZQNe86gG4jfmEol0CRRx1Xl00Lh2TJLUt+k EEDyilYXPUyQl3ZBgUucf3XOljyb9W2QA0p49CxUPVqjv2tqq1irvKguB /xW/YpF+Wbd14YY6mGHT4N6MaG9v/dvdWikLpjvmDllhb4Ado5ryt4RNg Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="312539880" X-IronPort-AV: E=Sophos;i="5.88,356,1635231600"; d="scan'208";a="312539880" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 08:41:23 -0800 X-IronPort-AV: E=Sophos;i="5.88,356,1635231600"; d="scan'208";a="482386274" Received: from smile.fi.intel.com ([10.237.72.61]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 08:41:21 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nHq11-002g3O-CS; Wed, 09 Feb 2022 18:40:23 +0200 Date: Wed, 9 Feb 2022 18:40:23 +0200 From: Andy Shevchenko To: Javier Martinez Canillas Cc: Geert Uytterhoeven , Linux Kernel Mailing List , Daniel Vetter , Maxime Ripard , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , DRI Development , Linux Fbdev development list Subject: Re: [PATCH v3 5/7] (WIP) drm/solomon: Add SSD130X OLED displays SPI support Message-ID: References: <20220209090314.2511959-1-javierm@redhat.com> <20220209091204.2513437-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Wed, Feb 09, 2022 at 05:07:03PM +0100, Javier Martinez Canillas wrote: > On 2/9/22 16:17, Andy Shevchenko wrote: > > On Wed, Feb 09, 2022 at 01:25:46PM +0100, Geert Uytterhoeven wrote: > >> On Wed, Feb 9, 2022 at 10:12 AM Javier Martinez Canillas > >> wrote: > > > > ... > > > >>> + .compatible = "solomon,ssd1305fb-spi", > >> > >> This needs an update to the DT bindings. > >> Hence this may be a good time to deprecate the existing > >> "solomon,ssd130*fb-i2c" compatible values, and switch to > >> "solomon,ssd130*fb" instead, for both I2C and SPI. > > > > Agree! > > > > Did you see my comment about automatic module loading ? I think > that would be an issue if we use the same compatible for both > I2C and SPI drivers. Bug in OF code? This is not a problem in ACPI AFAICT. -- With Best Regards, Andy Shevchenko