From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2341C433EF for ; Wed, 16 Mar 2022 16:52:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231304AbiCPQxd (ORCPT ); Wed, 16 Mar 2022 12:53:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357688AbiCPQxR (ORCPT ); Wed, 16 Mar 2022 12:53:17 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B7793701C; Wed, 16 Mar 2022 09:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647449522; x=1678985522; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=M6xWvkasIs+4Huuwh1wbLinzgQqked41NLVqaR8etdQ=; b=WqdHC6+IZo0bW+qlxs3j8rxcI9HapZid24R6z2nLa49doQA8yHWa5doK hnyb3M2jFB7rA8s9PFCCzMcJGh30VoDcFOZAcoU1Ccen9gFNgbwwM9D1C zlvGgi1rGIrdrEwDlM4GuowC1rRo99VTS7pHm7hQrQpIaJJl7YG0Y8jEl 2oL2Dodry7TbDqaI573A/w89NvvfYBu3lFiH1vm/7HMAkzeBX/bk9Mhos dWQw+paMGVGwXYkUTTIQm0QwGBlKQlEdK591Z3zoj8XpnrPx0Zo25cRLp bO+FoMJF6pC3p1sphIqBOTvFDTEZLcMGSEEqAi3nq5Yb7z8P1cV3mksUQ w==; X-IronPort-AV: E=McAfee;i="6200,9189,10288"; a="281443925" X-IronPort-AV: E=Sophos;i="5.90,187,1643702400"; d="scan'208";a="281443925" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 09:52:02 -0700 X-IronPort-AV: E=Sophos;i="5.90,187,1643702400"; d="scan'208";a="635058087" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 09:52:00 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nUWro-0010gf-UM; Wed, 16 Mar 2022 18:51:20 +0200 Date: Wed, 16 Mar 2022 18:51:20 +0200 From: Andy Shevchenko To: Greg Kroah-Hartman Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] staging: fbtft: Consider type of init sequence values in fbtft_init_display() Message-ID: References: <20220304193414.88006-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Mon, Mar 14, 2022 at 06:28:41PM +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 04, 2022 at 09:34:14PM +0200, Andy Shevchenko wrote: ... > Any reason you didn't test build this? My test build doesn't include the WERROR for this driver, so I missed the warning. Sorry for that. Now fixed. > drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_init_display’: > drivers/staging/fbtft/fbtft-core.c:1038:48: error: passing argument 3 of ‘fbtft_dbg_hex’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] > 1038 | s16, &par->init_sequence[i + 1], j, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/staging/fbtft/fbtft.h:441:50: note: in definition of macro ‘fbtft_par_dbg_hex’ > 441 | fbtft_dbg_hex(dev, sizeof(type), buf,\ > | ^~~ > drivers/staging/fbtft/fbtft-core.c:52:26: note: expected ‘void *’ but argument is of type ‘const s16 *’ {aka ‘const short int *’} > 52 | void *buf, size_t len, const char *fmt, ...) > | ~~~~~~^~~ > LD [M] drivers/staging/gdm724x/gdmulte.o > cc1: all warnings being treated as errors -- With Best Regards, Andy Shevchenko