From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C4CBC433FE for ; Thu, 21 Apr 2022 06:32:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240678AbiDUGe5 (ORCPT ); Thu, 21 Apr 2022 02:34:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242783AbiDUGex (ORCPT ); Thu, 21 Apr 2022 02:34:53 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8BE8513F36; Wed, 20 Apr 2022 23:32:05 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F2B92811B; Thu, 21 Apr 2022 06:29:13 +0000 (UTC) Date: Thu, 21 Apr 2022 09:32:03 +0300 From: Tony Lindgren To: Arnd Bergmann Cc: linux-omap@vger.kernel.org, aaro.koskinen@iki.fi, jmkrzyszt@gmail.com, Arnd Bergmann , Russell King , Paul Walmsley , Kevin Hilman , Peter Ujfalusi , Vinod Koul , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Mark Brown , Felipe Balbi , Alan Stern , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Linus Walleij , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, dmaengine@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, linux-serial@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 24/41] ARM: omap: un-merge plat/sram.c Message-ID: References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-25-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419133723.1394715-25-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org * Arnd Bergmann [220419 13:37]: > From: Arnd Bergmann > > The sram initialization code is the only shared omap1/2 code that > is not a standalone driver, but it is very short. Having two copies > of this code means some duplication of the sources, but actually > saves object code size as it can be inlined better. FYI, the sram code should eventually be updated to use drivers/misc/sram.c, I recall there being some issues to deal with for PM related code though. Probably the PM related save and restore could be now handled with cpu_pm. Regards, Tony