From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Uri Arev <me@wantyapps.xyz>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Len Baker" <len.baker@gmx.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Srivathsa Dara" <srivathsa729.8@gmail.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: fix checkpatch.pl struct should normally be const
Date: Thu, 19 May 2022 23:09:25 +0300 [thread overview]
Message-ID: <Yoaj9baQHs9gZpz5@smile.fi.intel.com> (raw)
In-Reply-To: <20220519172503.10821-1-me@wantyapps.xyz>
On Thu, May 19, 2022 at 08:25:01PM +0300, Uri Arev wrote:
> This simple patch fixes a checkpatch.pl warning in `fbtft/fbtft-core.c`.
>
> Reported by Checkpatch:
> WARNING: struct fb_ops should normally be const
...
> - fbops = devm_kzalloc(dev, sizeof(struct fb_ops), GFP_KERNEL);
> + const fbops = devm_kzalloc(dev, sizeof(struct fb_ops), GFP_KERNEL);
Why?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-05-19 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 17:25 [PATCH] staging: fbtft: fix checkpatch.pl struct should normally be const Uri Arev
2022-05-19 20:09 ` Andy Shevchenko [this message]
2022-05-19 21:25 ` kernel test robot
2022-05-20 0:41 ` kernel test robot
2022-05-20 1:34 ` kernel test robot
2022-05-20 6:03 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yoaj9baQHs9gZpz5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=len.baker@gmx.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=me@wantyapps.xyz \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
--cc=srivathsa729.8@gmail.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).