From: Mark Brown <broonie@kernel.org>
To: ChiaEn Wu <peterwu.pub@gmail.com>
Cc: lee.jones@linaro.org, daniel.thompson@linaro.org,
jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
sre@kernel.org, chunfeng.yun@mediatek.com,
gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de,
lgirdwood@gmail.com, linux@roeck-us.net,
heikki.krogerus@linux.intel.com, deller@gmx.de,
cy_huang@richtek.com, alice_chen@richtek.com,
chiaen_wu@richtek.com, dri-devel@lists.freedesktop.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 03/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support
Date: Tue, 31 May 2022 14:41:42 +0200 [thread overview]
Message-ID: <YpYNBo90NETXtjkV@sirena.org.uk> (raw)
In-Reply-To: <20220531102809.11976-4-peterwu.pub@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On Tue, May 31, 2022 at 06:27:58PM +0800, ChiaEn Wu wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Add mt6370 DisplayBias and VibLDO support.
Other than one small thing this looks nice and clean:
> + enable_gpio = fwnode_gpiod_get_index(of_fwnode_handle(np), "enable", 0,
> + GPIOD_OUT_HIGH |
> + GPIOD_FLAGS_BIT_NONEXCLUSIVE,
> + desc->name);
> + if (IS_ERR(enable_gpio)) {
> + config->ena_gpiod = NULL;
> + return 0;
> + }
Please just use the OF APIs - due to ACPI's handling of power for
devices the regulator API OF bindings can't be used sensibly on
ACPI so it's better to explicitly work on DT only. This won't
actually cause problems here but it's a bit clearer.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-31 12:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 10:27 [PATCH 00/14] Add Mediatek MT6370 PMIC support ChiaEn Wu
2022-05-31 10:27 ` [PATCH 01/14] mfd: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-05-31 10:27 ` [PATCH 02/14] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver ChiaEn Wu
2022-05-31 10:27 ` [PATCH 03/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support ChiaEn Wu
2022-05-31 12:41 ` Mark Brown [this message]
2022-05-31 10:27 ` [PATCH 04/14] iio: adc: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-05-31 10:28 ` [PATCH 05/14] power: supply: mt6370: Add Mediatek MT6370 charger driver ChiaEn Wu
2022-05-31 10:28 ` [PATCH 06/14] leds: mt6370: Add Mediatek MT6370 Indicator support ChiaEn Wu
2022-06-01 9:48 ` Andy Shevchenko
2022-06-01 9:51 ` Andy Shevchenko
2022-06-02 6:26 ` ChiYuan Huang
2022-06-02 9:17 ` Andy Shevchenko
2022-06-02 9:35 ` ChiYuan Huang
2022-05-31 10:28 ` [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support ChiaEn Wu
2022-06-01 9:57 ` Andy Shevchenko
2022-06-02 12:07 ` szuni chen
2022-06-02 13:57 ` Andy Shevchenko
2022-06-02 13:59 ` Andy Shevchenko
2022-05-31 10:28 ` [PATCH 08/14] video: backlight: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-05-31 10:28 ` [PATCH 09/14] dt-bindings: usb: Add Mediatek MT6370 TCPC binding documentation ChiaEn Wu
2022-06-01 7:26 ` Krzysztof Kozlowski
2022-05-31 10:28 ` [PATCH 10/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger " ChiaEn Wu
2022-05-31 10:28 ` [PATCH 11/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 indicator documentation ChiaEn Wu
2022-05-31 10:28 ` [PATCH 12/14] dt-bindings: leds: Add Mediatek MT6370 flashlight binding documentation ChiaEn Wu
2022-05-31 10:28 ` [PATCH 13/14] dt-bindings: backlight: Add Mediatek MT6370 backlight " ChiaEn Wu
2022-06-01 7:34 ` Krzysztof Kozlowski
2022-05-31 10:28 ` [PATCH 14/14] dt-bindings: mfd: Add Mediatek MT6370 " ChiaEn Wu
2022-05-31 20:46 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpYNBo90NETXtjkV@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alice_chen@richtek.com \
--cc=chiaen_wu@richtek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).