From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A50DEC433EF for ; Wed, 8 Jun 2022 16:13:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245140AbiFHQNH (ORCPT ); Wed, 8 Jun 2022 12:13:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245128AbiFHQM7 (ORCPT ); Wed, 8 Jun 2022 12:12:59 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01EF69D067 for ; Wed, 8 Jun 2022 09:12:57 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id m39-20020a05600c3b2700b0039c511ebbacso4610023wms.3 for ; Wed, 08 Jun 2022 09:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=n+Pp6leHahzsRX/bjpWot1i7bHMvU8Jw6pimNZGVd9s=; b=U1ceR5ZcHswI2Sd6KQrOPHJiGYKs46BbN5DhWHhymN8bn24CnHFEv9h4pok5hPGD3w jtbZsEEyfsWZkzAq2XX3Bt58jMt/PkaYTxuKlstiuZETjCajfneQsnM2NAVdVMotDp4T l0/Xi4zqdZhrzd/qm6KINqX3L7yIQExgk80nY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=n+Pp6leHahzsRX/bjpWot1i7bHMvU8Jw6pimNZGVd9s=; b=iIeetFCAlVd6/LWFGkxs0Qm1+OEqBTzI2Gl1eRajdZtWMI5lFGyWlMRNzblj/7ynTV BMxYKc6XpoZbs8mN/9tpxnC3dZmkj08Tob49tRdXNLffn+yALvKQgobecBtFeAmcWk04 YrbbCNbTbQEhQSpK7MEdRMUt6ue2JQI9jQVTeH/RknbhVHgkoHKu0kHGSuh6iyA+Xllf b0UcarlLFVQPvOnheOU5qbEQhg+WRh4KUz/QQaHIbM2PswI8+XdQtBYl8BwC397h4apf InxwKejqeOpmJaW7rRoXZ4BvF7fgtz5Hr8OcM3Spjmy4q6paaKlXBAZs1VtkEpY0rYkh ZMtA== X-Gm-Message-State: AOAM533z32kzV62dTMq0TPVsuZrSYIv0hkp9IIvPAkrLrKO9ru2AiwSL wKAWXeUHL2RyFcJ+TodY3yk4fQ== X-Google-Smtp-Source: ABdhPJyJ1hMy6o1A7TSEc2gTjfLM3QKvFpOpwuorCz0WhSKILm+zibt0P8DOxJq7tYRjUCVn59zhfA== X-Received: by 2002:a7b:c341:0:b0:37b:c619:c9f4 with SMTP id l1-20020a7bc341000000b0037bc619c9f4mr64819074wmj.38.1654704776193; Wed, 08 Jun 2022 09:12:56 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h9-20020a5d4309000000b002102af52a2csm27095440wrq.9.2022.06.08.09.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 09:12:54 -0700 (PDT) Date: Wed, 8 Jun 2022 18:12:53 +0200 From: Daniel Vetter To: Helge Deller Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] fbcon: Fix accelerated fbdev scrolling while logo is still shown Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Thu, Jun 02, 2022 at 10:08:38PM +0200, Helge Deller wrote: > There is no need to directly skip over to the SCROLL_REDRAW case while > the logo is still shown. > > When using DRM, this change has no effect because the code will reach > the SCROLL_REDRAW case immediately anyway. > > But if you run an accelerated fbdev driver and have > FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION enabled, console scrolling is > slowed down by factors so that it feels as if you use a 9600 baud > terminal. > > So, drop those unnecessary checks and speed up fbdev console > acceleration during bootup. > > Signed-off-by: Helge Deller > Cc: stable@vger.kernel.org I'm not entirely sure this is 100% perfect, but I don't think it'll make anything worse, so Acked-by: Daniel Vetter I'm assuming you'll push this to drm-misc-fixes? I pinged drm-misc maintainers to make sure that tree is forwarded to -rc1. -Daniel > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c > index c2f9e5711c39..8eb5b73e98bc 100644 > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -1706,8 +1706,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, > case SM_UP: > if (count > vc->vc_rows) /* Maximum realistic size */ > count = vc->vc_rows; > - if (logo_shown >= 0) > - goto redraw_up; > switch (fb_scrollmode(p)) { > case SCROLL_MOVE: > fbcon_redraw_blit(vc, info, p, t, b - t - count, > @@ -1796,8 +1794,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, > case SM_DOWN: > if (count > vc->vc_rows) /* Maximum realistic size */ > count = vc->vc_rows; > - if (logo_shown >= 0) > - goto redraw_down; > switch (fb_scrollmode(p)) { > case SCROLL_MOVE: > fbcon_redraw_blit(vc, info, p, b - 1, b - t - count, -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch