From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C98C3C43334 for ; Wed, 8 Jun 2022 16:26:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245214AbiFHQ0v (ORCPT ); Wed, 8 Jun 2022 12:26:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245415AbiFHQ0r (ORCPT ); Wed, 8 Jun 2022 12:26:47 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 805F413F33 for ; Wed, 8 Jun 2022 09:26:39 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id e5so4344031wma.0 for ; Wed, 08 Jun 2022 09:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=PlENWwzlCM90o/vUAucZ/2PTf41RpbELMXSIvxOkRsg=; b=kUamzuMZKjBGedJ41D2CVba2W72DHDvLXgAu+IRALCFkrP3w078R1o53D+vRCSe01F rNkY2vVwnVV2VRLzYbzS3O+P9k5lDvVgJ5mKk0zXBbWb6hvTVl/V8nJzd0Lu6k2UhewB bsL613wbo/x5NaZd+K7hm5wT4WUp6zMhwLUQ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=PlENWwzlCM90o/vUAucZ/2PTf41RpbELMXSIvxOkRsg=; b=ij/350YqJwfsxkTKLacM+iMhEqco8u0xVUVE9rCrF30kZg76pIsGcrHLl/Kdz1gkNk 6cdcCBWAR5o/Ine+1/EUby/1O5ivLSiI+CfR9eA736UUWQMw7f8hdhKXKMIR7UdQOyC5 49Dy2Vt6XaVDJ50Da3EIC8kA+aGA5gRehZFnquyAWD/CPewtGFfJUOnTyUgrK8OxBG4n iDKyx3nxKmjQ03e5AXswpq0Xk9u1lvCI6u8MlO6DFItjcGiKY0fhOgB4EWtmN0H4lalM ODIMVSTlMJeN7HLAFfP5QJfqu76faafqGSNtSolsERplC1bYnJVfCfnSVPq5pTYaBpja g3NQ== X-Gm-Message-State: AOAM533z/ZMtPmqcs3eHAMvcOxID30yqmUqKj7gr+ehYVQyOPyFQAu87 T73KENPJTmAIWVhNDW6khwbeHw== X-Google-Smtp-Source: ABdhPJyf8Brmkv7/K+wwJLIHpp3flqMDoBonSFPbtVBOY+CiA4pt1qQf2htU+BvHHGfYnZWx/UoWTA== X-Received: by 2002:a05:600c:a42:b0:393:d831:bf05 with SMTP id c2-20020a05600c0a4200b00393d831bf05mr33885940wmq.187.1654705597681; Wed, 08 Jun 2022 09:26:37 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id e7-20020adff347000000b0020ff4b8efc6sm21701293wrp.80.2022.06.08.09.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 09:26:36 -0700 (PDT) Date: Wed, 8 Jun 2022 18:26:34 +0200 From: Daniel Vetter To: Bjorn Helgaas Cc: Helge Deller , linux-fbdev@vger.kernel.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Vaibhav Gupta , Bjorn Helgaas Subject: Re: [PATCH 0/2] video: fbdev: Convert from PCI to generic power management Message-ID: Mail-Followup-To: Bjorn Helgaas , Helge Deller , linux-fbdev@vger.kernel.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Vaibhav Gupta , Bjorn Helgaas References: <20220607231112.354165-1-helgaas@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607231112.354165-1-helgaas@kernel.org> X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Tue, Jun 07, 2022 at 06:11:10PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > PCI-specific power management (pci_driver.suspend and pci_driver.resume) is > deprecated. If drivers implement power management, they should use the > generic power management framework, not the PCI-specific hooks. > > No fbdev drivers actually implement PCI power management, but there are a > cirrusfb has some commented-out references to it and skeletonfb has > examples of it. Remove these. Is this holding up some cleanup on your side and so would be easier to merge these through the pci tree? If so Acked-by: Daniel Vetter for merging through your tree. Otherwise I guess Helge will get around to pile them up for 5.20 (or 6.0) eventually. Cheers, Daniel > > Bjorn Helgaas (2): > video: fbdev: cirrusfb: Remove useless reference to PCI power > management > video: fbdev: skeletonfb: Convert to generic power management > > drivers/video/fbdev/cirrusfb.c | 6 ------ > drivers/video/fbdev/skeletonfb.c | 13 +++++++------ > 2 files changed, 7 insertions(+), 12 deletions(-) > > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch