From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E0DC433EF for ; Fri, 10 Jun 2022 09:47:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347221AbiFJJr0 (ORCPT ); Fri, 10 Jun 2022 05:47:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347199AbiFJJrY (ORCPT ); Fri, 10 Jun 2022 05:47:24 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05EE45F8D6 for ; Fri, 10 Jun 2022 02:47:19 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id o8so7926698wro.3 for ; Fri, 10 Jun 2022 02:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=OPbvFpgsCXrc/RPsUnJXvMubbP17Qr2YxU9/bS1wZjk=; b=Sx9VSFOKuSIF/SG/wZmN6t3GEVIdE7lEIrbl9Mm6OhO6ibXPIulugZeY3eOarE4gWg Xmxf7UQrHvFKBv/T01+affQqxcOeCFb1i3fIGXdkw5hb2dEDXYgTkvw4vOo6uE4njvOA Cr+H0XBeSDbYhAPd/i/bPJeriwwqBIj+qQ0CY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=OPbvFpgsCXrc/RPsUnJXvMubbP17Qr2YxU9/bS1wZjk=; b=V0wu7LZOV6E8NqNOuTvRdhrRCdb8/pOQd5mMQ0A2MqjmblTFe47bs7FLaQOs2tygm6 6z7sB1Eetg0PWuuWy025HopWlcLf4Res6JLmxZ2UNa1A8oW1Z3WL/mzvzssI7NM0teEd 2EbNQnD9lwNnNsFX1Xj9t5JlkTIMC5CevSF9MMkEjMLcDmpsMdCgVpbA7JMCrWw9PseB zP9FptnDEAU+I7pwtoR5LxJmhVseY7S5+RiAKzQujzO0MgKgH0dRXdzIRbwcc2K2uP3q pH0Z8d+5hkULHTN2K+VnMZMNmydnAzHvMtFJnxfAJxfum9fos9dWUIcDW9ef4QIYDM6U ldPQ== X-Gm-Message-State: AOAM530yuWs2LtR/MxIQ/16XT9mOaZItCIY5o4slE05H53VsN7+7wR5d ddqk6YFcgTeGDyXlNbh0OD/l2A== X-Google-Smtp-Source: ABdhPJw/3X2seKC/9g3emEoshWFl3NznfblFRQrKNLuh5mPnwP52ajg48RkiCudO7VotgG18/i6y3Q== X-Received: by 2002:adf:e4cb:0:b0:219:b63c:d238 with SMTP id v11-20020adfe4cb000000b00219b63cd238mr7519156wrm.705.1654854438519; Fri, 10 Jun 2022 02:47:18 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h18-20020a05600c351200b0039c50d2d28csm2364864wmq.44.2022.06.10.02.47.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 02:47:17 -0700 (PDT) Date: Fri, 10 Jun 2022 11:47:15 +0200 From: Daniel Vetter To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Stephen Rothwell , linux-fbdev@vger.kernel.org, kernel test robot , Helge Deller , dri-devel@lists.freedesktop.org, Thomas Zimmermann Subject: Re: [PATCH] Revert "fbdev: vesafb: Allow to be built if COMPILE_TEST is enabled" Message-ID: Mail-Followup-To: Javier Martinez Canillas , linux-kernel@vger.kernel.org, Stephen Rothwell , linux-fbdev@vger.kernel.org, kernel test robot , Helge Deller , dri-devel@lists.freedesktop.org, Thomas Zimmermann References: <20220610085450.1341880-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220610085450.1341880-1-javierm@redhat.com> X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Fri, Jun 10, 2022 at 10:54:50AM +0200, Javier Martinez Canillas wrote: > This reverts commit fa0e256450f27a7d85f65c63f05e6897954a1d53. The kernel > test robot reported that attempting to build the vesafb driver fails on > some architectures, because these don't define a `struct screen_info`. > > This leads to linking errors, for example on parisc with allyesconfig: > > hppa-linux-ld: drivers/video/fbdev/vesafb.o: in function `vesafb_probe': > >> (.text+0x738): undefined reference to `screen_info' > >> hppa-linux-ld: (.text+0x73c): undefined reference to `screen_info' > hppa-linux-ld: drivers/firmware/sysfb.o: in function `sysfb_init': > >> (.init.text+0x28): undefined reference to `screen_info' > >> hppa-linux-ld: (.init.text+0x30): undefined reference to `screen_info' > hppa-linux-ld: (.init.text+0x78): undefined reference to `screen_info' > > The goal of commit fa0e256450f2 ("fbdev: vesafb: Allow to be built if > COMPILE_TEST is enabled") was to have more build coverage for the driver > but it wrongly assumed that all architectures would define a screen_info. > > Reported-by: kernel test robot > Signed-off-by: Javier Martinez Canillas Acked-by: Daniel Vetter > --- > > drivers/video/fbdev/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index bd849013f16f..f2a6b81e45c4 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -616,7 +616,7 @@ config FB_UVESA > > config FB_VESA > bool "VESA VGA graphics support" > - depends on (FB = y) && (X86 || COMPILE_TEST) > + depends on (FB = y) && X86 > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > -- > 2.36.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch