From: Daniel Vetter <daniel@ffwll.ch>
To: Helge Deller <deller@gmx.de>
Cc: dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v5 4/4] fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible()
Date: Sun, 26 Jun 2022 11:59:04 +0200 [thread overview]
Message-ID: <Yrgt6PIyHz3dzJIk@phenom.ffwll.local> (raw)
In-Reply-To: <20220626085615.53728-5-deller@gmx.de>
On Sun, Jun 26, 2022 at 10:56:15AM +0200, Helge Deller wrote:
> Use the fbcon_info_from_console() wrapper which was added to kernel
> v5.19 with commit 409d6c95f9c6 ("fbcon: Introduce wrapper for console->fb_info lookup").
>
> Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/video/fbdev/core/fbcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 69c7261ac334..2ab7515ac842 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -2751,7 +2751,7 @@ int fbcon_modechange_possible(struct fb_info *info, struct fb_var_screeninfo *va
> /* prevent setting a screen size which is smaller than font size */
> for (i = first_fb_vc; i <= last_fb_vc; i++) {
> vc = vc_cons[i].d;
> - if (!vc || registered_fb[con2fb_map[i]] != info)
> + if (!vc || fbcon_info_from_console(i) != info)
> continue;
>
> if (vc->vc_font.width > FBCON_SWAP(var->rotate, var->xres, var->yres) ||
> --
> 2.35.3
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2022-06-26 9:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 8:56 [PATCH v5 0/4] fbcon: Fixes for screen resolution changes Helge Deller
2022-06-26 8:56 ` [PATCH v5 1/4] fbcon: Disallow setting font bigger than screen size Helge Deller
2022-06-26 8:56 ` [PATCH v5 2/4] fbmem: Prevent invalid virtual screen sizes Helge Deller
2022-06-26 8:56 ` [PATCH v5 3/4] fbcon: Prevent that screen size is smaller than font size Helge Deller
2022-06-26 9:58 ` Daniel Vetter
2022-06-26 8:56 ` [PATCH v5 4/4] fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible() Helge Deller
2022-06-26 9:59 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrgt6PIyHz3dzJIk@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox