From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA92CCA473 for ; Mon, 27 Jun 2022 16:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239224AbiF0Q2V (ORCPT ); Mon, 27 Jun 2022 12:28:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239230AbiF0Q2R (ORCPT ); Mon, 27 Jun 2022 12:28:17 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DFCAB4BE for ; Mon, 27 Jun 2022 09:28:13 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id b26so1439350wrc.2 for ; Mon, 27 Jun 2022 09:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RFbscGfZ1HvqkolFfPgOHxRAqCYKsO6AGhI1CWcF3U0=; b=QL9P5fYJiAGJ0cVberqQxZgecUlCyO035Rs/RHERScTvlSGjFZWJwcJ83NKx7icnCf MmmkqeK7/MKYHkhThvS+4I5n6eilA1iv0cTdd1jM4UXHDDaaVEXvSnXIRzJWnCUCUcUi hfbpR0k3AwYuP7wFzDx1Qb4iWIpTN9nBpMOsMz5YzOvQfMZ+aNGdk1BwqtUaNtHKCBDC fA9t5x0TJ4kWUQmeUPz8VsbAvV+0a4AUoZiJIyO7qENghiYMyKTM8whwQHTooEBVZnfa hv7NO7jkwT4JYF/WPaOvNMBn/r4c0lJo2uE2cyoUPVH1HBvXxtPYqUUryaiaIppTOHk7 Xteg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RFbscGfZ1HvqkolFfPgOHxRAqCYKsO6AGhI1CWcF3U0=; b=77nOHoklfhilsAPtN2EmgXd9kpafYzwUn+TfE/6/jVSgBAu22HBktM8z0XSpm3vToA nGVOWkrCstDjzE2oAEHEpZHcy6bPz2OxhjmKYpxsoq6CFa+gugooMjmhyd0gT0uauCTm MTXhGHzripcWUZl9HQBDcc8YBT8L2TDi00ypMkgNjecxAlYpqNI8iPzk7EzeO74joxNa joyjZV3r4wmlbYjwH6IDqZcrYuQt5hOSibFNFOGPwbAZysR2BVgeemfIMtn/VKTdrdpz e5NkTHA9YyxaZMUO4L9WLYWg9exw/ULEXzBp7OpMEOHTZBA8KeQEgxqztK0EyN1pkVsc 9q9Q== X-Gm-Message-State: AJIora/Nur6JT/pxkC2D9qcX/XQNeLM5I7HxZE1EcOFFsWNeMrUU2Tg9 8OJsNH+Ba5UGcl73xazw00Yp9A== X-Google-Smtp-Source: AGRyM1tWghCzrhvaQKuNnG4CtD67zaV7MVCuo84J73jDL9LXJFGuDL/uN51RLsUeyYqHqBL/FNulUA== X-Received: by 2002:a5d:5966:0:b0:21b:80b5:ecc3 with SMTP id e38-20020a5d5966000000b0021b80b5ecc3mr12930472wri.130.1656347292409; Mon, 27 Jun 2022 09:28:12 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id m17-20020adfe0d1000000b0021b866397a7sm11132854wri.1.2022.06.27.09.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 09:28:12 -0700 (PDT) Date: Mon, 27 Jun 2022 17:28:09 +0100 From: Lee Jones To: ChiaEn Wu Cc: Jonathan Cameron , Lars-Peter Clausen , Matthias Brugger , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , linux-iio , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , dri-devel , Linux LED Subsystem , devicetree , Linux PM , USB , "open list:FRAMEBUFFER LAYER" , szuni chen , ChiYuan Huang Subject: Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support Message-ID: References: <20220613111146.25221-1-peterwu.pub@gmail.com> <20220613111146.25221-9-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org [...] > > > > > +#define MT6370_IRQ_DSV_VPOS_OCP 124 > > > > > +#define MT6370_IRQ_DSV_BST_OCP 125 > > > > > +#define MT6370_IRQ_DSV_VNEG_SCP 126 > > > > > +#define MT6370_IRQ_DSV_VPOS_SCP 127 > > > > > + > > > > > +struct mt6370_info { > > > > > + struct i2c_client *i2c[MT6370_MAX_I2C]; > > > > > + struct device *dev; > > > > > + struct regmap *regmap; > > > > > + struct regmap_irq_chip_data *irq_data; > > > > > +}; > > > > > > > > Can we shove all of the above into a header file? > > > > > > Well... In Patch v1, we put these "#define IRQ" into > > > "include/dt-bindings/mfd/mediatek,mt6370.h". > > > But the reviewer of DT files hoped us to remove this header file, we > > > put these "#define IRQ" in this .c file. > > > Shall we leave them here or put them into the header file in > > > "driver/power/supply/mt6370-charger.h"? > > > > Where are they used? > > Sorry, I wrote the wrong path last time... > What I should say last time was to put them into the header file into > "driver/mfd/mt6370.h" > These "#define IRQ" are just used in "driver/mfd/mt6370.c" > I’m really sorry for making this mistake... Yes, that would be fine. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog