From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A46FC43334 for ; Sun, 24 Jul 2022 09:46:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233822AbiGXJqW (ORCPT ); Sun, 24 Jul 2022 05:46:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231218AbiGXJqU (ORCPT ); Sun, 24 Jul 2022 05:46:20 -0400 Received: from mailrelay2-1.pub.mailoutpod1-cph3.one.com (mailrelay2-1.pub.mailoutpod1-cph3.one.com [46.30.210.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 904C113DE2 for ; Sun, 24 Jul 2022 02:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=DkqpzAchLXmtZywchvjBdLq8pdyVIUoiP+DnnHhldOI=; b=BqV2fDL81ealynMunuznONsHsFq0sfsdNKC7RJ9ZtvsujhTttTWp60gHst53eGHxqEP/6EfH8DOED 9Hf3PlKrc4a71S//wp43pfIsJdKzbiC6cQ8vAXIWP5iQTgsjNIdN7lacamSIoUGNZEo6Cv/2DTz8yZ Bf69ZT7l0aOWR8gxLC0ZqX6d+cli+xCq6xaUZYSkSPVRSL5gwX2wvsaz4ivaYVQ8+WOr2Z9klH7Bct WQvlwAuCPT/QHzcexHODhHchdmzlnrv6iTWkBd2TYbHRbUxBxx68ZU+IU03V1niI5Ne8R3jloNmCVM LYr4d1VBfp68nIYUQykWE/r2P4k+mMg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=DkqpzAchLXmtZywchvjBdLq8pdyVIUoiP+DnnHhldOI=; b=aGMFzsceyms8TAATok1Fggo3By2K2dVTVcoCOoFgLKPJyGL8t22OzyxgXuL6zRxO9h3C5Rl7QL2Fu EzpRu7GAg== X-HalOne-Cookie: 6aee22b5d60a7eee958282967307d05ab7c8cbec X-HalOne-ID: 76912f13-0b35-11ed-a918-d0431ea8a290 Received: from mailproxy1.cst.dirpod3-cph3.one.com (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay2.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 76912f13-0b35-11ed-a918-d0431ea8a290; Sun, 24 Jul 2022 09:46:17 +0000 (UTC) Date: Sun, 24 Jul 2022 11:46:15 +0200 From: Sam Ravnborg To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-fbdev@vger.kernel.org, Sascha Hauer , dri-devel@lists.freedesktop.org, NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , Helge Deller , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/4] video: fb: imxfb: Drop platform data support Message-ID: References: <20220723175720.76933-1-u.kleine-koenig@pengutronix.de> <20220723220218.2jxejv55aix5sqra@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Uwe, On Sun, Jul 24, 2022 at 11:40:22AM +0200, Sam Ravnborg wrote: > Hi Uwe, > > On Sun, Jul 24, 2022 at 12:02:18AM +0200, Uwe Kleine-König wrote: > > Hi Sam, > > > > On Sat, Jul 23, 2022 at 09:23:43PM +0200, Sam Ravnborg wrote: > > > On Sat, Jul 23, 2022 at 07:57:17PM +0200, Uwe Kleine-König wrote: > > > > No source file but the driver itself includes the header containing the > > > > platform data definition. The last user is gone since commit > > > > 8485adf17a15 ("ARM: imx: Remove imx device directory"). > > > > > > > > So we can safely drop platform data support. > > > > > > > > Signed-off-by: Uwe Kleine-König > > > > > > Do imxfb offer something that is not supported by the DRM drivers? > > > If yes then the clean-up is good, if not then we could drop the driver? > > > > It's for different i.MX variants. imxfb is for i.MX2x while the DRM > > drivers in mainline are for i.MX6. (Not sure about the i.MX3 and i.MX5x > > variants.) > > > > Somewhere in the middle of my todo list is to mainline an i.MX2x DRM > > driver that could replace the imxfb driver. If I only had a bit more > > time ... > > There is drm/mxsfb, where Kconfig says: > "including i.MX23, i.MX28, i.MX6SX, i.MX7 and i.MX8M". > > So there is already something but if this is a 1:1 replacement I dunno. I suddenly remembered we had the following commit: f225f1393f034e17281274180626086276da766c ("video: fbdev: mxsfb: Remove driver") So the fbdev counterpart of drm/mxsfb is already dropped. Sam