* [PATCH -next v2] backlight: gpio_backlight: Switch to use dev_err_probe() helper
@ 2022-09-26 14:24 Yang Yingliang
2022-09-26 15:32 ` Daniel Thompson
0 siblings, 1 reply; 4+ messages in thread
From: Yang Yingliang @ 2022-09-26 14:24 UTC (permalink / raw)
To: linux-fbdev, dri-devel; +Cc: lee, daniel.thompson, jingoohan1, yangyingliang
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
v2:
Remove "Error: " in error meassage
---
drivers/video/backlight/gpio_backlight.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
index 6f78d928f054..4ff3939e5f7e 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev)
def_value = device_property_read_bool(dev, "default-on");
gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
- if (IS_ERR(gbl->gpiod)) {
- ret = PTR_ERR(gbl->gpiod);
- if (ret != -EPROBE_DEFER)
- dev_err(dev,
- "Error: The gpios parameter is missing or invalid.\n");
- return ret;
- }
+ if (IS_ERR(gbl->gpiod))
+ return dev_err_probe(dev, PTR_ERR(gbl->gpiod),
+ "The gpios parameter is missing or invalid.\n");
memset(&props, 0, sizeof(props));
props.type = BACKLIGHT_RAW;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next v2] backlight: gpio_backlight: Switch to use dev_err_probe() helper
2022-09-26 14:24 [PATCH -next v2] backlight: gpio_backlight: Switch to use dev_err_probe() helper Yang Yingliang
@ 2022-09-26 15:32 ` Daniel Thompson
2022-09-27 2:17 ` Yang Yingliang
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Thompson @ 2022-09-26 15:32 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-fbdev, dri-devel, lee, jingoohan1
On Mon, Sep 26, 2022 at 10:24:47PM +0800, Yang Yingliang wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> v2:
> Remove "Error: " in error meassage
> ---
> drivers/video/backlight/gpio_backlight.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index 6f78d928f054..4ff3939e5f7e 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> def_value = device_property_read_bool(dev, "default-on");
>
> gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
> - if (IS_ERR(gbl->gpiod)) {
> - ret = PTR_ERR(gbl->gpiod);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev,
> - "Error: The gpios parameter is missing or invalid.\n");
> - return ret;
> - }
> + if (IS_ERR(gbl->gpiod))
> + return dev_err_probe(dev, PTR_ERR(gbl->gpiod),
> + "The gpios parameter is missing or invalid.\n");
Why keep the leading "The " ?
Daniel.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next v2] backlight: gpio_backlight: Switch to use dev_err_probe() helper
2022-09-26 15:32 ` Daniel Thompson
@ 2022-09-27 2:17 ` Yang Yingliang
2022-09-28 15:45 ` Daniel Thompson
0 siblings, 1 reply; 4+ messages in thread
From: Yang Yingliang @ 2022-09-27 2:17 UTC (permalink / raw)
To: Daniel Thompson; +Cc: linux-fbdev, dri-devel, lee, jingoohan1, yangyingliang
Hi
On 2022/9/26 23:32, Daniel Thompson wrote:
> On Mon, Sep 26, 2022 at 10:24:47PM +0800, Yang Yingliang wrote:
>> In the probe path, dev_err() can be replaced with dev_err_probe()
>> which will check if error code is -EPROBE_DEFER and prints the
>> error name. It also sets the defer probe reason which can be
>> checked later through debugfs. It's more simple in error path.
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>> v2:
>> Remove "Error: " in error meassage
>> ---
>> drivers/video/backlight/gpio_backlight.c | 10 +++-------
>> 1 file changed, 3 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
>> index 6f78d928f054..4ff3939e5f7e 100644
>> --- a/drivers/video/backlight/gpio_backlight.c
>> +++ b/drivers/video/backlight/gpio_backlight.c
>> @@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev)
>> def_value = device_property_read_bool(dev, "default-on");
>>
>> gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
>> - if (IS_ERR(gbl->gpiod)) {
>> - ret = PTR_ERR(gbl->gpiod);
>> - if (ret != -EPROBE_DEFER)
>> - dev_err(dev,
>> - "Error: The gpios parameter is missing or invalid.\n");
>> - return ret;
>> - }
>> + if (IS_ERR(gbl->gpiod))
>> + return dev_err_probe(dev, PTR_ERR(gbl->gpiod),
>> + "The gpios parameter is missing or invalid.\n");
> Why keep the leading "The " ?
OK, I will remove it in v3.
But you says "the resulting line will read better with a "The " at
beginning" in your last mail,
I am confused about this.
Thanks,
Yang
>
>
> Daniel.
> .
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next v2] backlight: gpio_backlight: Switch to use dev_err_probe() helper
2022-09-27 2:17 ` Yang Yingliang
@ 2022-09-28 15:45 ` Daniel Thompson
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Thompson @ 2022-09-28 15:45 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-fbdev, dri-devel, lee, jingoohan1
On Tue, Sep 27, 2022 at 10:17:32AM +0800, Yang Yingliang wrote:
> Hi
>
> On 2022/9/26 23:32, Daniel Thompson wrote:
> > On Mon, Sep 26, 2022 at 10:24:47PM +0800, Yang Yingliang wrote:
> > > In the probe path, dev_err() can be replaced with dev_err_probe()
> > > which will check if error code is -EPROBE_DEFER and prints the
> > > error name. It also sets the defer probe reason which can be
> > > checked later through debugfs. It's more simple in error path.
> > >
> > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> > > ---
> > > v2:
> > > Remove "Error: " in error meassage
> > > ---
> > > drivers/video/backlight/gpio_backlight.c | 10 +++-------
> > > 1 file changed, 3 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> > > index 6f78d928f054..4ff3939e5f7e 100644
> > > --- a/drivers/video/backlight/gpio_backlight.c
> > > +++ b/drivers/video/backlight/gpio_backlight.c
> > > @@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> > > def_value = device_property_read_bool(dev, "default-on");
> > >
> > > gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
> > > - if (IS_ERR(gbl->gpiod)) {
> > > - ret = PTR_ERR(gbl->gpiod);
> > > - if (ret != -EPROBE_DEFER)
> > > - dev_err(dev,
> > > - "Error: The gpios parameter is missing or invalid.\n");
> > > - return ret;
> > > - }
> > > + if (IS_ERR(gbl->gpiod))
> > > + return dev_err_probe(dev, PTR_ERR(gbl->gpiod),
> > > + "The gpios parameter is missing or invalid.\n");
> > Why keep the leading "The " ?
> OK, I will remove it in v3.
>
> But you says "the resulting line will read better with a "The " at
> beginning" in your last mail,
> I am confused about this.
That's because my e-mail was confusing! Thanks for fixing it.
Daniel.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-28 15:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-26 14:24 [PATCH -next v2] backlight: gpio_backlight: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-26 15:32 ` Daniel Thompson
2022-09-27 2:17 ` Yang Yingliang
2022-09-28 15:45 ` Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).