From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 991782063C6 for ; Mon, 16 Dec 2024 14:41:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734360096; cv=none; b=fLjHuGFMJLwb0uFBLge559P6H5+Lr04xXgTmMbsU2jaV7Ao/B4IL5U/z2px0UNb8KJevuyZHPRnWedJQ5EU4SjrsGSCbaXCXmqXswE7PxcQb5pFIzQafoTfqorGcMKaUbkN1zt/s5tRtE/DO3GOdUKjst1Si3t4ykf6CLtBObwg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734360096; c=relaxed/simple; bh=ZkTcKDsd9BdbAnRGxaGqA8Jgxq5P1M+PcZ2ULpoGr4M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aF4f2GXGDYY4HZgdixvqUpJRSZHnxhUf8dDT+4PzTtpQRxa2MivzjvL+6wQr+6+bKw4bWqDHiwNESMJGtl69drr2q/G8P7p283xmdAQF+p7tr8AtdBEoJ27NcVJwmlBdNOi4hJAVfr5isBJxQ3XWYvxuSTDjkNTARbzZRrz/7n8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch; spf=none smtp.mailfrom=ffwll.ch; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b=iv265xx6; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="iv265xx6" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-436326dcb1cso18426665e9.0 for ; Mon, 16 Dec 2024 06:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1734360093; x=1734964893; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=h4e0o/EChopge9iHDGlCcrGi54fhpHon4WXwZ2Or538=; b=iv265xx6zM6AEwuaakdBOiq4KQ/rBOMn/1eOcyUNxhcOFxHlxj47vDwwabC1gy8MMc xV6AcD1Tmdf3ciE9PorL8EIcyeAVAFBObqHXnr2rqGrduq4QsdBYtlAPcwEEw0xOclGm feULbrV7WY46/gUmUWKOw8vr20KsSQwkwVRkc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734360093; x=1734964893; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h4e0o/EChopge9iHDGlCcrGi54fhpHon4WXwZ2Or538=; b=aFhzKSfDxh5h2j/d0z6FRM+mEfnFZYYDzNkTinHLRUGMeGzz7lugNU65/9cI6E9eSf uN933vdU5Rrw1vc6mGJfD49VuW9mB6s7Sf8Ic3O9tA3c+R5ym8C7gke36AFhmg1yqenC QgNhIWj8kVQCUyk+agDRYSlEdgOZAh+YwVEu/J0VsTu60R+scgDbTiEm+0ET9Rjzxt7Q 2FxO51xrFgE/DJiaW3o7mRTTfdtrMpZaatSWgRZUOQQMA4/QEhc7q3Si6i0TwBeZ/rd4 6TUtvNG0lVA3MWm/GpXFzBoAer6lWS33nXFFrv4OZAuFUQ9qYT/W39MQQOarSfTygytg Ruig== X-Forwarded-Encrypted: i=1; AJvYcCUJaaNgf8s++WxkJJBid+ZIaTJlV3tBE7Wfqsuv6F1kHHnZk10q7935iFvcG+LihuWBZVBjdV8KHoN9bA==@vger.kernel.org X-Gm-Message-State: AOJu0YxpViQMXXsW2S4wuHcTX4OvunnOgyMXfKgLR1UpoCV19VHnqYZo x9bhyRR9qVVTrThFOalDREmo4l7nwapp7z7PD15E4ApK84bIySTft9NVL4lc3Q0= X-Gm-Gg: ASbGncs0YTChAbLZeRfI0FpZL1mkiQpK0a14l4SRkKMbvrlssv4JkUP1KbDPn+/JD3h 6f+3kJ4Ty21l5YP06ajD1vvpBZ52g1qYCcWNW8tfD/BhUsx+gaeceBnjOsjifKJYBoxlo4nRqn1 RlXUrGJtwANqv8JDFRZU8voCE8uhv1PV6MiacBR+EennA++hWdr2pIKTgTNwjtAjHyvaz6wqTp0 80+wUlHmFv5NOAT16VVAxxb3pWFeI8mDGEoLs/eIL4HzwuWdG0vEHYo+pmmX5PbdhEF X-Google-Smtp-Source: AGHT+IHNuXaQbcaOzWDlJLVdH2VVVV7M1p7IawdDEoc0b+Y3XGEWD6gvsewijzhv1O9NvZ73cJsOkA== X-Received: by 2002:a05:6000:1544:b0:385:f47a:e9d1 with SMTP id ffacd0b85a97d-38880ac7641mr8437760f8f.17.1734360092860; Mon, 16 Dec 2024 06:41:32 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:5485:d4b2:c087:b497]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c8016c0bsm8410974f8f.42.2024.12.16.06.41.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 06:41:32 -0800 (PST) Date: Mon, 16 Dec 2024 15:41:30 +0100 From: Simona Vetter To: Thomas Zimmermann Cc: Helge Deller , Jani Nikula , Arnd Bergmann , Javier Martinez Canillas , Simona Vetter , Dave Airlie , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE Message-ID: References: <20241212100636.45875-1-tzimmermann@suse.de> <20241212100636.45875-2-tzimmermann@suse.de> <09edb59a-527a-4ddb-bfaf-ea74fb5a3023@gmx.de> <88ce6863-4458-47cb-9b28-274c91bd8764@app.fastmail.com> <87frmstrhd.fsf@intel.com> <2701e824-d330-49c0-88fa-a26658a9710c@gmx.de> <5566a3f5-496a-4b39-a0fa-6a1a5af9a67a@suse.de> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5566a3f5-496a-4b39-a0fa-6a1a5af9a67a@suse.de> X-Operating-System: Linux phenom 6.12.3-amd64 On Fri, Dec 13, 2024 at 08:26:19AM +0100, Thomas Zimmermann wrote: > Hi > > > Am 13.12.24 um 00:56 schrieb Helge Deller: > > On 12/13/24 00:24, Jani Nikula wrote: > > > On Thu, 12 Dec 2024, "Arnd Bergmann" wrote: > > > > On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: > > > > > On 12/12/24 11:04, Thomas Zimmermann wrote: > > > > > > Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter > > > > > > only controls backlight support within fbdev core code and data > > > > > > structures. > > > > > > > > > > > > Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users > > > > > > select it explicitly. Fixes warnings about recursive dependencies, > > > > > > such as [...] > > > > > > > > > > I think in the fbdev drivers themselves you should do: > > > > >     select BACKLIGHT_CLASS_DEVICE > > > > > instead of "depending" on it. > > > > > This is the way as it's done in the DRM tiny and the > > > > > i915/gma500 DRM drivers. > > > > > > > > > > So, something like: > > > > > > > > > > --- a/drivers/staging/fbtft/Kconfig > > > > >          tristate "Support for small TFT LCD display modules" > > > > >          depends on FB && SPI > > > > >          depends on FB_DEVICE > > > > >     +    select BACKLIGHT_DEVICE_CLASS > > > > >          depends on GPIOLIB || COMPILE_TEST > > > > >          select FB_BACKLIGHT > > > > > > > > > > config FB_BACKLIGHT > > > > >             tristate > > > > >             depends on FB > > > > >     -      select BACKLIGHT_CLASS_DEVICE > > > > >     +       depends on BACKLIGHT_CLASS_DEVICE > > > > > > > > > > > > > > > Would that fix the dependency warning? > > > > > > > > The above is generally a mistake and the root cause of the > > > > dependency loops. With very few exceptions, the solution in > > > > these cases is to find the inconsistent 'select' and change > > > > it into 'depends on'. > > > > > > Agreed. > > > > That's fine, but my point is that it should be consistent. > > For example: > > > > ~:/git-kernel/linux$ grep -r "select.*BACKLIGHT_CLASS_DEVICE" > > drivers/gpu/ > > drivers/gpu/drm/tilcdc/Kconfig: select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/nouveau/Kconfig:        select BACKLIGHT_CLASS_DEVICE if > > DRM_NOUVEAU_BACKLIGHT > > drivers/gpu/drm/nouveau/Kconfig:        select BACKLIGHT_CLASS_DEVICE if > > ACPI && X86 > > drivers/gpu/drm/tiny/Kconfig:   select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/tiny/Kconfig:   select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/tiny/Kconfig:   select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/tiny/Kconfig:   select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/tiny/Kconfig:   select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/tiny/Kconfig:   select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/tiny/Kconfig:   select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/fsl-dcu/Kconfig:        select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/i915/Kconfig:   select BACKLIGHT_CLASS_DEVICE if ACPI > > drivers/gpu/drm/gma500/Kconfig: select BACKLIGHT_CLASS_DEVICE if ACPI > > drivers/gpu/drm/amd/amdgpu/Kconfig:     select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/xe/Kconfig:     select BACKLIGHT_CLASS_DEVICE if ACPI > > drivers/gpu/drm/solomon/Kconfig:        select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/radeon/Kconfig: select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/renesas/shmobile/Kconfig:       select > > BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/gud/Kconfig:    select BACKLIGHT_CLASS_DEVICE > > drivers/gpu/drm/bridge/Kconfig: select BACKLIGHT_CLASS_DEVICE > > > > All major drm graphics drivers *select* BACKLIGHT_CLASS_DEVICE. > > Are you changing them to "depend on" as well? > > All these drivers should be changed to either 'depends on' or maybe 'imply'. Yeah, select on non-leaf/library function Kconfig symbols tends to be a complete pain. There's some push to use select so it's easier for people to enable complex drivers, but I honestly don't think it's worth it. menuconfig can give you a list of things you need to enable first, so it's all discoverable enough (but a bit painful to get them all if it's a really complex driver with lots of dependencies). tldr; I concur fully, please no more select but instead less. -Sima > > Best regards > Thomas > > > > > Helge > > -- > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Frankenstrasse 146, 90461 Nuernberg, Germany > GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman > HRB 36809 (AG Nuernberg) > -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch