From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Helge Deller <deller@gmx.de>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Tony Lindgren <tony@atomide.com>,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Input: ads7846 - fix up the pendown GPIO setup on Nokia 770
Date: Sun, 5 Jan 2025 23:02:27 -0800 [thread overview]
Message-ID: <Z3uAAy5vF2ezUS2c@google.com> (raw)
In-Reply-To: <CACRpkdbfuQuTQ028=hZgRhOPiw5AbPLyoZTbRCbvNDQ-e8UajQ@mail.gmail.com>
On Thu, Jan 02, 2025 at 10:32:00PM +0100, Linus Walleij wrote:
> On Thu, Jan 2, 2025 at 7:20 PM Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
>
> > The GPIO is set up as an IRQ, so request it as non-exclusive. Otherwise the
> > probe fails on Nokia 770 with:
> >
> > ads7846 spi2.0: failed to request pendown GPIO
> > ads7846: probe of spi2.0 failed with error -16
> >
> > Also the polarity is wrong. Fix it.
> >
> > Fixes: 767d83361aaa ("Input: ads7846 - Convert to use software nodes")
> > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Do we need to have this knowledge in the driver or can it be handled
in GPIO subsystem or affected board support? Requesting a GPIO with "in"
direction when it is also an interrupt source should be pretty common.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2025-01-06 7:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 18:19 [PATCH 0/3] Input/omap1: fix touchscreen functionality on Nokia 770 Aaro Koskinen
2025-01-02 18:19 ` [PATCH 1/3] fbdev: omap: use threaded IRQ for LCD DMA Aaro Koskinen
2025-01-02 21:31 ` Linus Walleij
2025-01-08 23:40 ` Helge Deller
2025-01-02 18:19 ` [PATCH 2/3] Input: ads7846 - fix up the pendown GPIO setup on Nokia 770 Aaro Koskinen
2025-01-02 21:32 ` Linus Walleij
2025-01-06 7:02 ` Dmitry Torokhov [this message]
2025-01-14 12:28 ` Linus Walleij
2025-01-14 21:51 ` Dmitry Torokhov
2025-01-02 18:19 ` [PATCH 3/3] Input: ads7846 - restore half-duplex support Aaro Koskinen
2025-01-02 21:35 ` [PATCH 0/3] Input/omap1: fix touchscreen functionality on Nokia 770 Linus Walleij
2025-01-03 0:39 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3uAAy5vF2ezUS2c@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=deller@gmx.de \
--cc=jmkrzyszt@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).