* [PATCH] fbtft: Remove access to page->index
@ 2025-02-21 17:31 Matthew Wilcox (Oracle)
2025-02-21 17:53 ` Lorenzo Stoakes
0 siblings, 1 reply; 5+ messages in thread
From: Matthew Wilcox (Oracle) @ 2025-02-21 17:31 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Matthew Wilcox (Oracle), Thomas Zimmermann, Jeff Johnson,
Thomas Petazzoni, dri-devel, linux-fbdev, linux-staging,
Lorenzo Stoakes
There is no need to print out page->index as part of the debug message.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
drivers/staging/fbtft/fbtft-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 4cfa494243b9..da9c64152a60 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -337,9 +337,7 @@ static void fbtft_deferred_io(struct fb_info *info, struct list_head *pagereflis
list_for_each_entry(pageref, pagereflist, list) {
y_low = pageref->offset / info->fix.line_length;
y_high = (pageref->offset + PAGE_SIZE - 1) / info->fix.line_length;
- dev_dbg(info->device,
- "page->index=%lu y_low=%d y_high=%d\n",
- pageref->page->index, y_low, y_high);
+ dev_dbg(info->device, "y_low=%d y_high=%d\n", y_low, y_high);
if (y_high > info->var.yres - 1)
y_high = info->var.yres - 1;
if (y_low < dirty_lines_start)
--
2.47.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] fbtft: Remove access to page->index
2025-02-21 17:31 [PATCH] fbtft: Remove access to page->index Matthew Wilcox (Oracle)
@ 2025-02-21 17:53 ` Lorenzo Stoakes
2025-03-04 16:21 ` Matthew Wilcox
0 siblings, 1 reply; 5+ messages in thread
From: Lorenzo Stoakes @ 2025-02-21 17:53 UTC (permalink / raw)
To: Matthew Wilcox (Oracle)
Cc: Greg Kroah-Hartman, Thomas Zimmermann, Jeff Johnson,
Thomas Petazzoni, dri-devel, linux-fbdev, linux-staging
On Fri, Feb 21, 2025 at 05:31:29PM +0000, Matthew Wilcox (Oracle) wrote:
> There is no need to print out page->index as part of the debug message.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
LGTM from my side,
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> drivers/staging/fbtft/fbtft-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> index 4cfa494243b9..da9c64152a60 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -337,9 +337,7 @@ static void fbtft_deferred_io(struct fb_info *info, struct list_head *pagereflis
> list_for_each_entry(pageref, pagereflist, list) {
> y_low = pageref->offset / info->fix.line_length;
> y_high = (pageref->offset + PAGE_SIZE - 1) / info->fix.line_length;
> - dev_dbg(info->device,
> - "page->index=%lu y_low=%d y_high=%d\n",
> - pageref->page->index, y_low, y_high);
> + dev_dbg(info->device, "y_low=%d y_high=%d\n", y_low, y_high);
> if (y_high > info->var.yres - 1)
> y_high = info->var.yres - 1;
> if (y_low < dirty_lines_start)
> --
> 2.47.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fbtft: Remove access to page->index
2025-02-21 17:53 ` Lorenzo Stoakes
@ 2025-03-04 16:21 ` Matthew Wilcox
2025-03-05 7:39 ` Simona Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Matthew Wilcox @ 2025-03-04 16:21 UTC (permalink / raw)
To: Lorenzo Stoakes
Cc: Greg Kroah-Hartman, Thomas Zimmermann, Jeff Johnson,
Thomas Petazzoni, dri-devel, linux-fbdev, linux-staging
On Fri, Feb 21, 2025 at 05:53:16PM +0000, Lorenzo Stoakes wrote:
> On Fri, Feb 21, 2025 at 05:31:29PM +0000, Matthew Wilcox (Oracle) wrote:
> > There is no need to print out page->index as part of the debug message.
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>
> LGTM from my side,
>
> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
This patch is not yet in linux-next; can I expect it to go in soon?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fbtft: Remove access to page->index
2025-03-04 16:21 ` Matthew Wilcox
@ 2025-03-05 7:39 ` Simona Vetter
2025-03-05 17:49 ` Matthew Wilcox
0 siblings, 1 reply; 5+ messages in thread
From: Simona Vetter @ 2025-03-05 7:39 UTC (permalink / raw)
To: Matthew Wilcox
Cc: Lorenzo Stoakes, Greg Kroah-Hartman, Thomas Zimmermann,
Jeff Johnson, Thomas Petazzoni, dri-devel, linux-fbdev,
linux-staging
On Tue, Mar 04, 2025 at 04:21:30PM +0000, Matthew Wilcox wrote:
> On Fri, Feb 21, 2025 at 05:53:16PM +0000, Lorenzo Stoakes wrote:
> > On Fri, Feb 21, 2025 at 05:31:29PM +0000, Matthew Wilcox (Oracle) wrote:
> > > There is no need to print out page->index as part of the debug message.
> > >
> > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> >
> > LGTM from my side,
> >
> > Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>
> This patch is not yet in linux-next; can I expect it to go in soon?
Being both staging and fbdev it's double orphaned, I stuffed it into
drm-misc-next now, thanks for the ping&patch.
-Sima
--
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fbtft: Remove access to page->index
2025-03-05 7:39 ` Simona Vetter
@ 2025-03-05 17:49 ` Matthew Wilcox
0 siblings, 0 replies; 5+ messages in thread
From: Matthew Wilcox @ 2025-03-05 17:49 UTC (permalink / raw)
To: Simona Vetter
Cc: Lorenzo Stoakes, Greg Kroah-Hartman, Thomas Zimmermann,
Jeff Johnson, Thomas Petazzoni, dri-devel, linux-fbdev,
linux-staging
On Wed, Mar 05, 2025 at 08:39:17AM +0100, Simona Vetter wrote:
> On Tue, Mar 04, 2025 at 04:21:30PM +0000, Matthew Wilcox wrote:
> > On Fri, Feb 21, 2025 at 05:53:16PM +0000, Lorenzo Stoakes wrote:
> > > On Fri, Feb 21, 2025 at 05:31:29PM +0000, Matthew Wilcox (Oracle) wrote:
> > > > There is no need to print out page->index as part of the debug message.
> > > >
> > > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> > >
> > > LGTM from my side,
> > >
> > > Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> >
> > This patch is not yet in linux-next; can I expect it to go in soon?
>
> Being both staging and fbdev it's double orphaned, I stuffed it into
> drm-misc-next now, thanks for the ping&patch.
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-05 17:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-21 17:31 [PATCH] fbtft: Remove access to page->index Matthew Wilcox (Oracle)
2025-02-21 17:53 ` Lorenzo Stoakes
2025-03-04 16:21 ` Matthew Wilcox
2025-03-05 7:39 ` Simona Vetter
2025-03-05 17:49 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).