From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22314C76196 for ; Tue, 11 Apr 2023 14:36:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229885AbjDKOge (ORCPT ); Tue, 11 Apr 2023 10:36:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229903AbjDKOgd (ORCPT ); Tue, 11 Apr 2023 10:36:33 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BC562134 for ; Tue, 11 Apr 2023 07:36:31 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f05f61adbeso1576345e9.0 for ; Tue, 11 Apr 2023 07:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1681223790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F/9s4MmBtHe5NsXKH5rsLF1epbFuabZfYBtz2rgF3IM=; b=AmK+ahYjvW6kcPI+mQhwW8Y+6uTX+p+DedJ4+XA7DXU/ms+JuRXcnfZNXaardwQqvD omIQWsGFb5a6X0Jz/KzGa+xx3SOV0eokfeDpfRppsTp41xyU8QY+T708i2wn/nIl6Hcn qt6f4PBGTeqm84d54siqW6hzbkWAscgeGzHQQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681223790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F/9s4MmBtHe5NsXKH5rsLF1epbFuabZfYBtz2rgF3IM=; b=HGLMjYu2qSFdm//xIZOHhLlOVTNIG7GqrMwyYUsYorpJIWVAL9V9BbenN94Gu/JmJg rRocb0X8YApf0mvOaw4iIVSDqK/RNdgMb/4IJyqmVtIxGAvZCnD/WVMA0+/1k4s7OqRO hDFfcQT4cBOEdoSP+Ii9N50hF7yPR3HlMX1R0SA0UJ9sUPMCOnvaFGV9VPesCb6Z3044 DiIbgvrPFgvcOjKFsWuAAmBWIh8tKNqAVc3jG3nquhkr0vDI7ssTzaUs0lvNVhensamd wFWItsZDGPZMUmKm/3f2hqUf931nfxhxYQHhAu/lFCsyw6b9knqvd8mqcIo0p+8Lgue7 kJow== X-Gm-Message-State: AAQBX9dp0dHXq5kZ+qXtKqR52WwgtNtWl1PoIERY8XuRCdEaPo812+EZ cBeD6ARJP+O0t5d2pTHCgWuLnw== X-Google-Smtp-Source: AKy350ZhwGv7Q0l6A1XUuXwX4y+iD6ltzBT4TmO43D5j7OgvC2eOzix0bm6ngX4Kwlgmlg1Fl/4AfA== X-Received: by 2002:a05:600c:1c1e:b0:3f0:5a8c:fee4 with SMTP id j30-20020a05600c1c1e00b003f05a8cfee4mr8043334wms.4.1681223790085; Tue, 11 Apr 2023 07:36:30 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-33.fiber7.init7.net. [212.51.149.33]) by smtp.gmail.com with ESMTPSA id h18-20020a05600c315200b003ef6708bc1esm21612534wmo.43.2023.04.11.07.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 07:36:29 -0700 (PDT) Date: Tue, 11 Apr 2023 16:36:27 +0200 From: Daniel Vetter To: Helge Deller Cc: Thomas Zimmermann , javierm@redhat.com, daniel.vetter@ffwll.ch, patrik.r.jakobsson@gmail.com, dri-devel@lists.freedesktop.org, Daniel Vetter , linux-fbdev@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org Subject: Re: [PATCH v5 2/9] video/aperture: use generic code to figure out the vga default device Message-ID: References: <20230406132109.32050-1-tzimmermann@suse.de> <20230406132109.32050-3-tzimmermann@suse.de> <85282243-33a6-a311-0b50-a7edfc4c4c6e@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85282243-33a6-a311-0b50-a7edfc4c4c6e@gmx.de> X-Operating-System: Linux phenom 6.1.0-7-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Fri, Apr 07, 2023 at 10:54:00PM +0200, Helge Deller wrote: > On 4/6/23 15:21, Thomas Zimmermann wrote: > > From: Daniel Vetter > > > > Since vgaarb has been promoted to be a core piece of the pci subsystem > > we don't have to open code random guesses anymore, we actually know > > this in a platform agnostic way, and there's no need for an x86 > > specific hack. See also commit 1d38fe6ee6a8 ("PCI/VGA: Move vgaarb to > > drivers/pci") > > > > This should not result in any functional change, and the non-x86 > > multi-gpu pci systems are probably rare enough to not matter (I don't > > know of any tbh). But it's a nice cleanup, so let's do it. > > > > There's been a few questions on previous iterations on dri-devel and > > irc: > > > > - fb_is_primary_device() seems to be yet another implementation of > > this theme, and at least on x86 it checks for both > > vga_default_device OR rom shadowing. There shouldn't ever be a case > > where rom shadowing gives any additional hints about the boot vga > > device, but if there is then the default vga selection in vgaarb > > should probably be fixed. And not special-case checks replicated all > > over. > > > > - Thomas also brought up that on most !x86 systems > > fb_is_primary_device() returns 0, except on sparc/parisc. But these > > 2 special cases are about platform specific devices and not pci, so > > shouldn't have any interactions. > > Nearly all graphics cards on parisc machines are actually PCI cards, > but the way we handle the handover to graphics mode with STIcore doesn't > conflicts with your planned aperture changes. > So no problem as far as I can see for parisc... Ah I thought sticore was some very special bus, if those can be pci cards underneath then I guess some cleanup eventually might be a good idea? For anything with a pci bus it's rather strange when vgaarb and fb_is_primary_device() aren't a match ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch